Skip to content

docs(rules): mark PRs ready and keep disagreements open #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zolotokrylin merged 2 commits into from
Sep 24, 2026
Merged

docs(rules): mark PRs ready and keep disagreements open #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85fa542
docs(rules): mark PRs ready and keep disagreements open
zolotokrylin Sep 17, 2026
ee517c3
Merge branch 'main' into docs/ci-stage-and-thread-disagreement
zolotokrylin Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/rules/DEV-365.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ opens half-finished work.
1. Include a preview link when the change is visually verifiable.
1. Mark ready for review only once the PR is a linked, self-assigned draft (per
[DEV-360](./DEV-360.md)) with a reviewer and a preview where applicable.
1. Resolve all CI checks. CI runs after the PR is marked ready, so do not
request approval until it passes.
1. Resolve all CI checks. Some checks run on drafts and some only once the PR is
marked ready, so fix draft-stage failures before marking it ready, and do not
request approval until every check passes.
1. Do not merge without an approved review and passing CI.

### Acceptance Criteria
Expand Down
8 changes: 5 additions & 3 deletions docs/rules/DEV-460.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ the thread settled; the reply carries the answer.

1. Reply to every inline thread before you merge, and name what changed. One
sentence is enough.
1. Resolve the thread after you post that reply and push the fix.
1. Resolve the thread after you post that reply and the answer is applied or
accepted: the fix is pushed, or the reviewer accepts an answer that needs no
change.
1. When you fixed it in another PR, the Problem, or a follow-up issue, say which
one and give its number.
1. Reply and leave the thread open when you disagree. The reviewer decides, per
[DEV-410](./DEV-410.md).
1. When you disagree, reply with why and leave the thread open. The reviewer
decides, per [DEV-410](./DEV-410.md).

```md
Good: fixed in 4a1c2f0, the heading is now `###`. [Resolve]
Expand Down
Loading