Skip to content

docs(rules): mark PRs ready and keep disagreements open - #167

Merged
zolotokrylin merged 2 commits into
mainfrom
docs/ci-stage-and-thread-disagreement
Sep 24, 2026
Merged

zolotokrylin merged 2 commits into
mainfrom
docs/ci-stage-and-thread-disagreement

Conversation

@zolotokrylin

@zolotokrylin zolotokrylin commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Authors can tell which CI failures block marking a PR ready and which only block approval, and a reviewer can see why an open thread is still open.

  • DEV-365: some checks run on drafts and some only once the PR is marked ready. The rule said CI runs only after ready, which read as "no CI gate before ready". Draft-stage failures are now fixed before marking ready, and approval still waits for every check.
  • DEV-460: a disagreement reply now has to say why, and a thread can be resolved when the reviewer accepts an answer that needs no code change, not only after a pushed fix.

Both gaps surfaced when a developer reviewed a project README that summarised these rules and followed the rule text literally.

Summary by CodeRabbit

  • Documentation
    • Updated CI guidance to account for checks that run on drafts and checks that run only after a pull request is marked ready.
    • Clarified that draft-stage failures must be fixed before marking a pull request ready and that approval should wait until all checks pass.
    • Updated review-thread guidance to allow resolution when a reviewer accepts an answer requiring no code change.
    • Clarified how authors should respond when they disagree with a reviewer’s feedback.

@zolotokrylin zolotokrylin self-assigned this Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ac443de6-fa3c-4458-a9a1-43e945d25ec2

📥 Commits

Reviewing files that changed from the base of the PR and between 85fa542 and ee517c3.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both main documentation changes: clarifying when to mark pull requests ready and keeping disagreement threads open until the reviewer accepts the response.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@holdex

holdex Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Time Submission Status

Member # Time Running Total Status Last Update
zolotokrylin 1 5min 5min Sep 17, 2026, 11:06 AM
zolotokrylin 2 +6min 11min Sep 24, 2026, 7:26 AM
zolotokrylin 11min ✅ Submitted

Submit or update total time with:

@holdex pr submit-time 2h

Add time on top of previous submission with:

@holdex pr add-time 1h30m

See available commands to help comply with our Guidelines.

@zolotokrylin zolotokrylin left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holdex pr add-time 5m

@zolotokrylin
zolotokrylin marked this pull request as ready for review September 17, 2026 11:06

@zolotokrylin zolotokrylin left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holdex pr add-time 6m

@zolotokrylin
zolotokrylin merged commit 84abbdd into main Sep 24, 2026
4 checks passed
@zolotokrylin
zolotokrylin deleted the docs/ci-stage-and-thread-disagreement branch September 24, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant