Skip to content

Fix fancy number - #25

Merged
vtm9 merged 3 commits into
hexlet-codebattle:mainfrom
dimaush:fix-fancy_number
Oct 16, 2026
Merged

vtm9 merged 3 commits into
hexlet-codebattle:mainfrom
dimaush:fix-fancy_number

Conversation

@dimaush

@dimaush dimaush commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Добавил в тесты числа с цифрами 2, 3, 4, 5, 7 и отрицательные (эталонное решение проверяло отсутствие других цифр, в то время как в тестах не было ни одной проверки на наличие этой проверки). Также изменил тип входа со строкового на целый (всё равно чисел по модулю больше чем 10^9 в тестах нет).

@vtm9 vtm9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional unsupported-digit tests are useful, but the new limits line is missing its closing $, so the constraint will not render as math.

The PR also changes the input from a decimal string to an integer, removing leading-zero representations such as "00", and introduces negative inputs without specifying how a minus sign behaves under rotation. The old task deliberately tested leading-zero strings. These are contract changes beyond adding coverage.

Please retain the string signature while broadening the allowed digits and adding the new negative cases only if their behavior is explicitly defined, or provide a clear reason for the integer contract change and define it completely. Fix the math delimiter in either case. All 30 submitted asserts pass.

@vtm9
vtm9 merged commit a6a04cf into hexlet-codebattle:main Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants