Repository navigation
Integrate reviewed contributions and fix task regressions - #28
Merged
Merged
Conversation
Fix misspell int -> integer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate contributions #14, #15, #16, #20, #25, and #26 with their original commits preserved, and fix the review findings before they reach main.
Correct IPv4 scanning after invalid candidates and retain arbitrary leading zeros. Preserve identifier boundaries after digits. Replace recursive flood fill with an iterative traversal and add a large-region regression. Resolve the pirate-task conflicts while preserving required scores and the empty Kraken position.
Add missing scores, align task paths with their first tags, and repair timing, limits, math escaping, and examples. Keep the integer input proposed for
fancy_number, explicitly defining negative numbers and zero. Keep the three-integer signature proposed forsum_of_two_equals_third, with valid boundary cases and elementary scoring. Support units withoutx1in expanded notation, as its examples require.New tasks:
center_strings,custom_fibonacci,digit_snake_formatter,expanded_notation_array,flood_fill,game_of_life_step,insert_interval,largest_perimeter_triangle,longest_balanced_segment,longest_common_prefix,max_stock_profit,maximum_altitude,minimum_bracket_reversals,peak_performance_sum,permutation_period,primes_with_prime_digit_sum,self_dividing_numbers,string_blocks_transposition,summary_ranges,toeplitz_matrix,topological_sort_possible,town_judge,turtle_max_path_sum,valid_sudoku.Changed existing tasks:
black_mark,broadside_salvo,fancy_number,feeding_kraken,log_ip_sanitizer,rum_thirst,sum_of_two_equals_third,underscore.Validation:
make buildpassed all 13,842 asserts across 505 tasks, including name and score/time checks. Checked schemas, paths, published input bounds, and all examples for the 32 changed tasks. Independent checks passed for 3,000 IPv4 cases, 1,331 signed triples, and 200 flood-fill grids plus the maximum 50×50 connected region. Repository pre-commit hooks passed.