One editor per workflow hierarchy: nested workflows in any file open in place - #64
Merged
Merged
Conversation
…in place A diagram whose nested workflows live in other files opened a new editor for every one drilled into -- a tab per level, each with its own chat, a Run button running the workflow on screen, and its own layout. With the profile's `nestedNavigation: 'in-place'` (default `'new-editor'`, so other products are unchanged), a drill-down or breadcrumb into any file shows that workflow in the same editor, as a view of the editor's root: - the client keys its navigation stack by the editor's root, and "Used By" goes in place to an ancestor, or opens a caller in another file as a new root with no trail; - the host keys the refresh context by the editor the request came from and remembers the shown file, so saves, external changes and live preview refresh the view shown (another file from disk); - the root runs: ▶ Run, ⟲ and "Rerun from Here" use the root, the latter rerunning the root-level instance a nested view is in, and a refresh during a run keeps the view rather than jumping to the root; - the chat stays the root's, and its turn context now names the nested view on screen and the file defining it; - "Open in Its Own Editor" on a nested workflow opens its file as a root of its own. Phases 1 and 2 of docs/proposals/single-editor-hierarchy.md. Claude-Session: https://claude.ai/code/session_015VK7fH1c4aKbexnq2QcuKU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phases 1 and 2 of
docs/proposals/single-editor-hierarchy.md(#63).A diagram whose nested workflows live in other files opened a new editor for every one you drilled into: a tab per level, each with its own chat, a Run button that ran the workflow on screen, and its own layout.
The profile flag
clientBehavior.nestedNavigation: 'in-place' | 'new-editor'controls this. The default is'new-editor', so other products are unchanged. With'in-place', every nested workflow in any file is a view inside the editor of the root (the file opened).Navigation (client)
RequestModelActionfor the defining file to the same editor, with the trail from the root.stackKey).Refresh (host)
getDocumentUriForClientId), not the file requested, and it remembersshownSourceUri.Root anchoring
__calDiagramContextgainsrootSourceUri,rootWorkflowNameandtrail.rootOfStackreturns the first crumb in place, otherwise the first crumb in the editor's own file.rerunActorFor), since the trace only has root-level steps.viewContextText).Not in this PR
The container-parity baseline gains the one new handler,
dialogram.openInOwnEditor.Tests
All workspaces pass, with neutrality 5/5 and typecheck 5/5. wfpy-ide turns the flag on in a separate PR.
https://claude.ai/code/session_015VK7fH1c4aKbexnq2QcuKU