The hierarchy button sits under chat, and going back returns a view to where it was - #68
Merged
Merged
Conversation
…o where it was The hierarchy outline's toggle floated on its own at the top left. It is now a button of the floating stack, directly under the chat button. Navigating back up a hierarchy put the graph off-center. A view was centered only the first time it was shown and kept its viewport only across a refresh, so returning to a view seen before landed it at the default scroll. Each view -- its file, workflow and instance path, so two instances of one workflow are two views -- now remembers where it was left: navigating back returns there, a view never shown is centered, and a refresh keeps the viewport as before (`settleViewport`). Claude-Session: https://claude.ai/code/session_015VK7fH1c4aKbexnq2QcuKU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the single-editor hierarchy navigation (#64, #67).
The hierarchy button was a toggle floating on its own at the top left. It is now a button of the floating stack, directly under the chat button. The stack is a reversed column, so "under chat" means just before it (
placeInButtonStack). It is placed again on every model change, because the stack and the chat button may be put in place after the outline's listener runs. Until a stack exists it floats where the stack will be.Navigating back put the graph off-center. A view was centered only the first time it was shown, and kept its viewport only across a refresh. Returning to a view seen before therefore landed it at the default scroll. Now each view remembers where it was left. A view is its file, workflow and instance path, so two instances of one workflow are two views (
modelViewportKey).The decision is the pure
settleViewport, andInitialViewportServiceis reduced tocenterSoon.Tests:
outline-button-and-viewport.test.ts(7). It covers the button under chat, a second placement leaving it put, the floating fallback, two instances being two views, a new view centered, navigating back restoring the viewport left, and a refresh keeping it. All workspaces pass, with neutrality 5/5 and typecheck 5/5. The container-parity baseline is unchanged.https://claude.ai/code/session_015VK7fH1c4aKbexnq2QcuKU