Repository navigation
Integrate community PRs #1–#26: 100% real-world corpus recompiles - #28
Merged
Merged
Conversation
Merges the 26 targeted decompiler fixes from @EiNSTeiN- (3.11-3.14 bytecode families) on top of main. Three textual conflicts were resolved by keeping both sides: PR #6 stacks on #5, all PRs append tests at the same point in tests/integration.rs, and #4/#5/#6/#24 append test-module declarations at the end of decompiler.rs. Verification with the standard release profile: - real-world corpus 6411/6411 recompile (was 6408/6411) - stdlib corpus 528/528 semantic pass (520 + 8 new padded fixtures) - behavior matrix: all cases pass on 3.9-3.14 (56 failures remain on 3.15, all pre-existing; main had 61 there) - cargo test: 37 integration + 8 + 27 unit tests pass README/CHANGELOG/LIMITATIONS updated (100% real-world, AST-equal 2493).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the 26 community PRs from @EiNSTeiN- (#1–#26) into one
verified branch. Every PR is included; none was dropped. The contributors'
fixes, fixtures, behavior cases, and integration tests are preserved, and
three textual conflicts were resolved by keeping both sides.
Why one branch
All 26 PRs are based on
25ed1ab2and touch the same two source files, somerging them one by one on GitHub produces repeated conflicts at the test
append point. This branch is the result of resolving those conflicts once
and running the full verification suite.
Verification (standard release profile)
maincargo testThe 56 remaining behavior failures are all on CPython 3.15 and are
pre-existing (
mainhas 61 there). This batch targets 3.11–3.14.main's behavior failures on 3.9–3.14 all come from the newly addedcases; the branch fixes them and does not regress any existing case.
Conflicts resolved
tests/integration.rs;both sides were kept and all 37 integration tests pass.
decompiler.rs; all declarations were kept.consolidated behavior/corpus gates cover the interaction.
Notes
keyword_call_arm_boundarycase intentionally emitsNone(...)plus the incomplete marker: it refuses to guess anevaluation-order-sensitive shape. This is consistent with the project's
"visible error over silently wrong code" rule.
if True:blocks;semantically correct, slightly verbose.
slice(...)calls instead of normalizing them tocolon syntax; this is more correct when
sliceis shadowed.Fixes #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11, #12, #13, #14, #15,
#16, #17, #18, #19, #20, #21, #22, #23, #24, #25, #26.