Repository navigation
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR to print a split try/except/else/finally AST as one valid Python statement, preserving all of its recovered suites.
Exception reconstruction can represent a statement as an outer Try with else/finally and a single inner Try holding the except clauses. Printing that structure literally produces an
elsewithout an associatedexceptat the same level:That output is invalid Python. The constrained split shape should print as:
The code generator rejoins only an outer try with no handlers, nonempty success and finally suites, and exactly one inner try that has handlers but no success or finally suite of its own. It preserves the inner body/handlers and the outer success/finally suites. A legitimate nested try/finally retains its nesting.
Unified try/except/finally syntax begins in Python 2.5, so the printer repair starts at that version. It is an AST repair rather than an opcode-specific one.
docs/LIMITATIONS.mdis updated to distinguish this repaired printing error from the remaining exception-region reconstruction problems inmultiprocessing.connection.