[bannarisoftwares]

Follow-up to #449. The hosted-target guard also rejected the shared E2E account's email, even though the dev account now has a private password stored in the E2E_INTEGRATION_TEST_* secrets. The guard now only refuses the public default password.

Summary by CodeRabbit

• Tests
  • Updated end-to-end credential checks so non-local targets are rejected when the password matches the public default test credential, regardless of the email address. This clarifies which credential value determines whether the check applies.

[qodo-code-review]

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: dculussoftwares/dculus-forms
• Branch: fix/e2e-hosted-credential-guard
• File: .coderabbit.yaml
• Commit: 0129606
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Essentials
• Run ID: b5bb75e6-2863-46e5-8913-f73f45958099

Commits

Reviewing files that changed from the base of the PR and between c645deb and 0129606.

Files selected for processing: 1

• test/e2e/steps/helpers/common.ts

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The E2E helper no longer uses the email address to decide whether to check that targets are local. It applies the existing non-local-target check when the password matches the public default.

Changes: Default credential check

Layer / File(s)	Summary
Password-based target check test/e2e/steps/helpers/common.ts	The helper returns early when the password differs from the public default, regardless of the email address. Otherwise, it retains the existing check for non-local targets.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Possibly related PRs

• dculussoftwares/dculus-forms#442: Documents the security risk of public default E2E credentials, which this change also addresses.

Merge Risk: Minimal · up to 01296

No actionable merge-blocking risk was identified in the reviewed change.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title states the main change: the guard that refuses the public default password now applies only to hosted targets. The raw summary confirms that assertDefaultCredentialsOnlyLocal no longer rejec…
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title states the main change: the guard that refuses the public default password now applies only to hosted targets. The raw summary confirms that assertDefaultCredentialsOnlyLocal no longer rejects based on the email, and the PR objectives describe the same goal. The title is specific, concise, and follows the conventional commit format.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}