Enable RuboCop EnforcedShorthandSyntax: always and autocorrect the codebase

.rubocop.yml

@@ -208,6 +208,7 @@ Style/GuardClause:
 
 Style/HashSyntax:
   Enabled: true
+  EnforcedShorthandSyntax: always
 
 Style/IfUnlessModifier:
   Enabled: false

app/controllers/admin/meeting_invitations_controller.rb

@@ -5,7 +5,7 @@ def update
     status = params.permit(:attendance_status)[:attendance_status]
     attended = params.permit(:attended)[:attended]
 
-    @invitation.update(attending: status, attended: attended)
+    @invitation.update(attending: status, attended:)
 
     redirect_to [:admin, @invitation.meeting],
                 notice: t('admin.messages.invitation.update_rsvp', name: @invitation.member.full_name)
@@ -15,12 +15,12 @@ def create
     member = Member.find(params[:meeting_invitations][:member])
     meeting = Meeting.find_by(slug: params[:meeting_invitations][:meeting_id])
 
-    if MeetingInvitation.accepted.where(meeting: meeting, member: member).exists?
+    if MeetingInvitation.accepted.where(meeting:, member:).exists?
       return redirect_to [:admin, meeting],
                          notice: t('admin.messages.invitation.already_on_list', name: member.full_name)
     end
 
-    invitation = meeting.invitations.find_or_create_by(member: member)
+    invitation = meeting.invitations.find_or_create_by(member:)
     invitation.assign_attributes(attending: true, role: 'Participant')
 
     if invitation.save

app/controllers/admin/meetings_controller.rb

@@ -54,7 +54,7 @@ def invite
   private
 
   def set_meeting
-    @meeting = Meeting.find_by!(slug: slug)
+    @meeting = Meeting.find_by!(slug:)
   end
 
   def slug

app/controllers/admin/member_search_controller.rb

@@ -17,12 +17,12 @@ def index
       redirect_to callback_url and return
     end
 
-    render 'index', locals: { members: members, callback_url: callback_url }
+    render 'index', locals: { members:, callback_url: }
   end
 
   def results
     pick_params = params.expect(member_pick: { members: [] })
     members = Member.find(pick_params[:members])
-    render 'show', locals: { members: members }
+    render 'show', locals: { members: }
   end
 end

app/controllers/admin/workshops_controller.rb

@@ -282,6 +282,6 @@ def set_sponsor
   end
 
   def workshop_sponsor(host = false)
-    @workshop_sponsor ||= WorkshopSponsor.new(workshop: @workshop, sponsor: @sponsor, host: host)
+    @workshop_sponsor ||= WorkshopSponsor.new(workshop: @workshop, sponsor: @sponsor, host:)
   end
 end

app/controllers/chapter_controller.rb

@@ -1,6 +1,6 @@
 class ChapterController < ApplicationController
   def show
-    @chapter = ChapterPresenter.new(Chapter.active.find_by!(slug: slug))
+    @chapter = ChapterPresenter.new(Chapter.active.find_by!(slug:))
 
     upcoming_workshops = upcoming_events_by_chapter(@chapter)
     @upcoming_workshops = event_presenters_by_date(upcoming_workshops)

app/controllers/concerns/workshop_invitation_concerns.rb

@@ -23,7 +23,7 @@ def back_with_message(message)
     end
 
     def set_invitation
-      @invitation = WorkshopInvitation.includes(:workshop, :member).find_by!(token: token)
+      @invitation = WorkshopInvitation.includes(:workshop, :member).find_by!(token:)
     end
   end
 end

app/controllers/contact_preferences_controller.rb

@@ -1,6 +1,6 @@
 class ContactPreferencesController < ApplicationController
   def show
-    @contact = Contact.find_by(token: token)
+    @contact = Contact.find_by(token:)
 
     return if @contact
 
@@ -9,7 +9,7 @@ def show
 
   def update
     contact = Contact.find_by!(token: contact_preferences[:token])
-    contact.update(mailing_list_consent: mailing_list_consent)
+    contact.update(mailing_list_consent:)
     ContactMailingListService.sync(contact)
     audit_contact_subscription(contact)
 

app/controllers/events_controller.rb

@@ -27,7 +27,7 @@ def show
 
     return unless logged_in?
 
-    invitation = Invitation.find_by(member: current_user, event: event, attending: true)
+    invitation = Invitation.find_by(member: current_user, event:, attending: true)
     redirect_to event_invitation_path(@event, invitation) if invitation
   end
 
@@ -44,7 +44,7 @@ def rsvp
     ticket = Services::Ticket.new(request, params)
     member = Member.find_by(email: ticket.email)
     invitation = member.invitations.where(event: @event, role: 'Student').first
-    invitation ||= Invitation.create_or_find_by(event: @event, member: member, role: 'Student')
+    invitation ||= Invitation.create_or_find_by(event: @event, member:, role: 'Student')
 
     invitation.update(attending: true)
     head :ok
@@ -63,8 +63,8 @@ def latest_model_updated
 
   def find_invitation_and_redirect_to_event(role)
     set_event
-    invitation = Invitation.create_or_find_by(event: @event, member: current_user, role: role)
-    invitation = Invitation.find_by(event: @event, member: current_user, role: role) unless invitation.persisted?
+    invitation = Invitation.create_or_find_by(event: @event, member: current_user, role:)
+    invitation = Invitation.find_by(event: @event, member: current_user, role:) unless invitation.persisted?
     redirect_to event_invitation_path(@event, invitation)
   end
 
@@ -135,7 +135,7 @@ def paginated_events(upcoming:)
     total = ActiveRecord::Base.connection.select_value(count_query.to_sql).to_i
     return nil if total.zero?
 
-    pagy_opts = { count: total, page: page, limit: 20, request: request }
+    pagy_opts = { count: total, page:, limit: 20, request: }
     pagy_opts[:request] = Pagy::Request.new(pagy_opts)
     pagy = Pagy::Offset.new(**pagy_opts)
 

app/controllers/invitations_controller.rb

@@ -36,12 +36,12 @@ def attend
         EventInvitationMailer.attending(@invitation.event, @invitation.member, @invitation).deliver_now
       end
       notice = t('messages.invitations.spot_not_confirmed') if event.surveys_required
-      redirect_back fallback_location: root_path, notice: notice
+      redirect_back fallback_location: root_path, notice:
     else
       email = event.chapters.present? ? event.chapters.first.email : 'hello@codebar.io'
       redirect_back(
         fallback_location: root_path,
-        notice: t('messages.invitations.event.no_available_seats', email: email)
+        notice: t('messages.invitations.event.no_available_seats', email:)
       )
     end
   end
@@ -95,7 +95,7 @@ def load_invitation
       MeetingInvitation.find_by(token: params[:token], member: current_user)
     else
       meeting = Meeting.find_by(slug: params[:meeting_id])
-      MeetingInvitation.new(meeting: meeting, member: current_user, role: 'Participant')
+      MeetingInvitation.new(meeting:, member: current_user, role: 'Participant')
     end
   end
 end

app/controllers/members_controller.rb

@@ -25,15 +25,15 @@ def profile
   def update
     if @member.update(member_params)
       notice = 'Your details have been updated.'
-      redirect_to profile_path, notice: notice
+      redirect_to profile_path, notice:
     else
       render 'edit'
     end
   end
 
   def unsubscribe
     require 'verifier'
-    member = Verifier.new(token: token).verify(Member)
+    member = Verifier.new(token:).verify(Member)
 
     session[:member_id] = member.id
 

app/controllers/subscriptions_controller.rb

@@ -8,7 +8,7 @@ def index
   end
 
   def create
-    subscription = Subscription.new(group_id: group_id, member: current_user)
+    subscription = Subscription.new(group_id:, member: current_user)
 
     if subscription.save
       SubscriptionMailingListService.subscribe(subscription)
@@ -23,7 +23,7 @@ def create
 
   def destroy
     # Don't error if subscription is not found
-    subscription = current_user.subscriptions.find_by(group_id: group_id)
+    subscription = current_user.subscriptions.find_by(group_id:)
     SubscriptionMailingListService.unsubscribe(subscription) if subscription
     subscription&.destroy
 

app/controllers/workshops_controller.rb

@@ -40,7 +40,7 @@ def role_params
   end
 
   def find_attending_invitation(workshop, user)
-    WorkshopInvitation.find_by(workshop: workshop, member: user, attending: true)
+    WorkshopInvitation.find_by(workshop:, member: user, attending: true)
   end
 
   def find_or_create_invitation(workshop, user, role)

app/helpers/email_header_helper.rb

@@ -19,9 +19,9 @@ def mail_to_member(member, subject, from_email = 'meetings@codebar.io', cc = '',
 
     mail(from: "codebar.io <#{from_email}>",
          to: member.email,
-         cc: cc,
-         bcc: bcc,
-         subject: subject,
+         cc:,
+         bcc:,
+         subject:,
          &block)
   end
 

app/models/chapter.rb

@@ -61,7 +61,7 @@ def eligible_coaches
   private
 
   def members_for_group(name)
-    members.where(groups: { name: name }).distinct
+    members.where(groups: { name: }).distinct
   end
 
   def expire_chapters_sidebar_cache

app/models/feedback.rb

@@ -8,7 +8,7 @@ class Feedback < ApplicationRecord
   validates :tutorial, presence: true
 
   def self.submit_feedback(params, token)
-    feedback_request = FeedbackRequest.find_by(token: token)
+    feedback_request = FeedbackRequest.find_by(token:)
     return false unless feedback_request
 
     feedback = Feedback.new(params)

app/models/meeting.rb

@@ -31,7 +31,7 @@ def to_param
   end
 
   def attending?(member)
-    invitations.accepted.where(member: member).present?
+    invitations.accepted.where(member:).present?
   end
 
   def not_full

app/models/waiting_list.rb

@@ -9,7 +9,7 @@ class WaitingList < ApplicationRecord
   scope :with_notes_and_their_authors, -> { includes(member: [{ member_notes: :author }, :attendance_warnings]) }
 
   def self.add(invitation, auto_rsvp = true)
-    find_or_create_by(invitation: invitation) do |waiting_list|
+    find_or_create_by(invitation:) do |waiting_list|
       waiting_list.auto_rsvp = auto_rsvp
     end
   end

app/serializers/workshop_calendar.rb

@@ -50,7 +50,7 @@ def configure(event, host_name:)
 
     event.url = invitation_url
     event.organizer = workshop.chapter.email.to_s
-    event.summary = I18n.t('workshop.calendar.summary', host_name: host_name)
+    event.summary = I18n.t('workshop.calendar.summary', host_name:)
     event.ip_class = 'PRIVATE'
   end
 

app/services/auditor.rb

@@ -16,16 +16,16 @@ def log(&block)
     end
 
     def log_with_note(note)
-      create(note: note)
+      create(note:)
     end
 
     private
 
     def create(changes)
       PublicActivity::Activity.create(trackable: model,
-                                      key: key,
+                                      key:,
                                       owner: user,
-                                      recipient: recipient,
+                                      recipient:,
                                       parameters: changes)
     end
   end

app/services/chapter_creation_service.rb

@@ -10,8 +10,8 @@ def self.call(params)
       chapter.groups.create!(name: 'Coaches')
     end
 
-    Result.new(chapter: chapter, success: true, errors: nil)
+    Result.new(chapter:, success: true, errors: nil)
   rescue ActiveRecord::RecordInvalid => e
-    Result.new(chapter: chapter, success: false, errors: e.message)
+    Result.new(chapter:, success: false, errors: e.message)
   end
 end

app/services/invitation_logger.rb

@@ -60,7 +60,7 @@ def finish_batch(total_invitees)
     return unless @log
 
     @log.update!(
-      total_invitees: total_invitees,
+      total_invitees:,
       completed_at: Time.current,
       status: :completed
     )
@@ -83,7 +83,7 @@ def resolved_chapter_id
   end
 
   def find_or_build_entry(member, invitation, status)
-    @log.entries.find_or_create_by(member: member, invitation: invitation) do |entry|
+    @log.entries.find_or_create_by(member:, invitation:) do |entry|
       entry.status = status
     end
   end

app/services/invitation_manager.rb

@@ -31,7 +31,7 @@ def send_monthly_attendance_reminder_emails(monthly)
 
   def send_meeting_emails(meeting)
     meeting.invitees.not_banned.each do |invitee|
-      invitation = MeetingInvitation.new(meeting: meeting, member: invitee, role: 'Participant')
+      invitation = MeetingInvitation.new(meeting:, member: invitee, role: 'Participant')
       next unless invitation.save
 
       MeetingInvitationMailer.invite(meeting, invitee, invitation).deliver_now
@@ -164,14 +164,14 @@ def chapter_coaches(chapter)
   end
 
   def create_invitation(workshop, member, role)
-    WorkshopInvitation.find_or_create_by!(workshop: workshop, member: member, role: role)
+    WorkshopInvitation.find_or_create_by!(workshop:, member:, role:)
   rescue StandardError => e
     log_invitation_failure(workshop, member, role, e)
     nil
   end
 
   def create_event_invitation(event, member, role)
-    Invitation.find_or_create_by!(event: event, member: member, role: role)
+    Invitation.find_or_create_by!(event:, member:, role:)
   rescue StandardError => e
     log_event_meeting_invitation_failure("event_id=#{event.id}", member, e)
     nil
@@ -260,7 +260,7 @@ def invitation_logger(loggable, initiator_id, audience, chapter_id)
     initiator = Member.find_by(id: initiator_id)
     return nil unless initiator
 
-    InvitationLogger.new(loggable, initiator, audience, :invite, chapter_id: chapter_id)
+    InvitationLogger.new(loggable, initiator, audience, :invite, chapter_id:)
   end
 
   def start_invitation_batch(logger)

app/services/three_month_email_service.rb

@@ -27,7 +27,7 @@ def self.send_chaser
                     .distinct
 
     members.find_each do |member|
-      MemberMailer.with(member: member).chaser.deliver_later
+      MemberMailer.with(member:).chaser.deliver_later
     end
   end
 end