Enable RuboCop EnforcedShorthandSyntax: always and autocorrect the codebase - #2834
Merged
Conversation
mroderick
marked this pull request as ready for review
August 31, 2026 13:06
mroderick
enabled auto-merge
August 31, 2026 13:07
mroderick
disabled auto-merge
August 31, 2026 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2833
Problem
Style/HashSyntaxwas enabled withEnforcedShorthandSyntaxleft at the defaulteither, so bothmember: memberandmember:were accepted and which one to write came down to reviewer preference.Change
EnforcedShorthandSyntax: alwayson the existingStyle/HashSyntaxcop in.rubocop.yml, so hash keywords matching a same-named local variable or method must use Ruby 3.1+ shorthand.bundle exec rubocop -ato autocorrect the existing backlog: 465 offenses across 105 files, all safe corrections (x: x→x:).rubocopis now clean..rubocop_todo.ymlentry needed — the sweep fixes everything, nothing deferred.