Skip to content

fix(project): align user-facing copy style - #2622

Merged
jariy17 merged 2 commits into
aws:refactorfrom
notgitika:fix/lowercase-project-copy
Oct 20, 2026
Merged

jariy17 merged 2 commits into
aws:refactorfrom
notgitika:fix/lowercase-project-copy

Conversation

@notgitika

Copy link
Copy Markdown
Contributor

Summary

  • start project progress, success, and next-step copy with lowercase text
  • lowercase the no-project TUI alert
  • simplify the root TUI descriptions for dev, deploy, status, and harness
  • remove implementation details such as the --mode flag from the dev description
  • update create, add, build, deploy, teardown, and export copy consistently

The root menu descriptions now read:

  • dev: develop and test project agents
  • deploy: build and deploy project resources to an AWS target
  • status: inspect deployed project resources for an AWS target
  • harness: manage config-defined agents and their versions

Context

This addresses cosmetic feedback from the CLI v1 bug bash. User-facing task labels and short descriptions follow the lowercase microcopy style, while full diagnostic error sentences remain unchanged.

Related Issue

Bug-bash feedback; no GitHub issue was filed.

Documentation PR

Not applicable; this changes CLI and TUI copy only.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other: cosmetic UX copy

Testing

  • I ran bun test — 4,687 tests passed
  • End-to-end tests are not applicable; these are copy-only changes covered by unit and rendered TUI tests
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • No assets or snapshots required updates

Checklist

  • I have read the CONTRIBUTING document
  • I updated affected tests for the new user-facing copy
  • No external documentation changes are required
  • My changes generate no new warnings
  • No dependent changes are required

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions Bot added the size/m PR size: M label Oct 19, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Oct 19, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 19, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Changes requested

The PR is a user-facing copy consistency pass, but it misses a few spots that are emitted into the same output streams as messages this PR just lowercased. The remaining capitals will show up right next to the lowercased ones at runtime, which is exactly the inconsistency the PR is trying to fix.

Issues

  1. Built project left capitalized — src/handlers/project/build/index.ts:16

    return `Built project '${project.name}'`;

    This is the summary line printed by the build handler, parallel to the deployed project / removed project lines in src/handlers/project/deploy/index.ts:38-42 that this PR did lowercase. Right now project.test.ts:1118 still asserts "Built project 'MyAgent'" and build/index.test.ts:72,84 assert "Built project 'orders'" — inconsistent with the deploy handler’s new wording. Please also lowercase Built project → built project and update the three build test assertions.

  2. CDK credential-provider step messages left capitalized — src/core/project/backends/cdk/credentials.ts:170, 267, 305

    yield { type: "step", message: `Removing credential provider '${provider}'` };
    yield { type: "step", message: `Preparing credential provider '${provider}'` };
    yield { type: "step", message: `Removing credential provider '${provider}' this deploy created` };

    These step events are interleaved with the ones in cdk.ts (which were lowercased), so a single deploy now emits a mix like:

    ✓ synthesizing CloudFormation templates
    ✓ Preparing credential provider 'openai-key'
    ✓ deploying AgentCore-example-default-0
    

    You can see the mismatch cleanly in cdk.test.ts after this PR, e.g. line 831/940:

    messages.indexOf("removing stack ...").toBeLessThan(messages.indexOf("Removing credential provider 'wallet'"))

    Please lowercase those three messages (and update the matching assertions in cdk.test.ts).

Optional, in the same spirit

If this pass is meant to be exhaustive, there are a few other step messages still starting with a capital that will show up alongside the lowercased ones in other flows: src/core/policy.tsx:51,64,77,102, src/cliVersionManager/manager.ts:102, and src/handlers/project/migrate/index.ts:115. Up to you whether those are in scope — flagging only so a follow-up isn’t needed.

Everything else in the diff looks like a straightforward and consistent rename.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 19, 2026
@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (d100e26) to head (773962b).

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2622      +/-   ##
============================================
- Coverage     96.61%   96.61%   -0.01%     
============================================
  Files           702      702              
  Lines         58347    58346       -1     
============================================
- Hits          56373    56371       -2     
- Misses         1974     1975       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jariy17
jariy17 previously approved these changes Oct 20, 2026

@jariy17 jariy17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good, look at the failing unit tests and the suggestions from harness reviewer.

tejaskash
tejaskash previously approved these changes Oct 20, 2026
@notgitika
notgitika dismissed stale reviews from tejaskash and jariy17 via 773962b October 20, 2026 14:55
@notgitika
notgitika force-pushed the fix/lowercase-project-copy branch from 79b5a4d to 773962b Compare October 20, 2026 14:55
@notgitika

Copy link
Copy Markdown
Contributor Author

Addressed the two actionable Harness findings in 773962b: lowercased the build success message and credential-provider progress messages, with their assertions updated. I left the optional policy/update/migrate copy suggestions out of scope for this PR.

I also investigated the macOS timeout. The reported online-eval test passes 20/20 in isolation; a normal local full-suite run later stalled on a different untouched test under host load, so this is suite/runner contention rather than a defect in that test. I did not add a timeout workaround. Fresh CI is running on the rebased branch.

@github-actions github-actions Bot added size/m PR size: M and removed size/m PR size: M labels Oct 20, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Oct 20, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 20, 2026
@jariy17
jariy17 merged commit c9c8d85 into aws:refactor Oct 20, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants