Repository navigation
test(e2e): align project success copy assertions - #2646
Merged
Merged
Conversation
jariy17
approved these changes
Oct 22, 2026
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Trivial follow-up to c9c8d851 fix(project): align user-facing copy style, which lowercased the deploy/teardown success messages (✔ deployed project '…' / ✔ removed project '…'). The three toContain assertions in e2eTest/project/harness.test.ts and e2eTest/project/templates.test.ts are updated to match the new casing — verified against src/handlers/project/buildDeploy.screen.test.tsx which uses the same lowercase strings. Nothing else to flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the project E2E assertions to match the intentional lowercase success copy introduced by #2622:
deployed projectremoved projectThis fixes the 12 assertion failures in the refactor branch E2E run: https://github.com/aws/agentcore-cli/actions/runs/39665585560/job/119457930294
Related Issue
Related to the failing refactor branch E2E run linked above.
Documentation PR
Not applicable; test-only change.
Type of Change
Testing
bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed thembun run buildpassed, and the staged-file lint and formatting hooks passed. The full format check was blocked by an unrelated localminimatchESM/CommonJS dependency error. The targeted E2E run was attempted against the authenticated test account, but the local bundle failed before reaching these assertions withlib is not definedduring CDK deployment; the referenced CI run completed deployment and failed only on the capitalization assertions corrected here.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.