Skip to content

test(e2e): align project success copy assertions - #2646

Merged
jariy17 merged 1 commit into
aws:refactorfrom
notgitika:fix/e2e-project-copy
Oct 22, 2026
Merged

jariy17 merged 1 commit into
aws:refactorfrom
notgitika:fix/e2e-project-copy

Conversation

@notgitika

@notgitika notgitika commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

Updates the project E2E assertions to match the intentional lowercase success copy introduced by #2622:

  • deployed project
  • removed project

This fixes the 12 assertion failures in the refactor branch E2E run: https://github.com/aws/agentcore-cli/actions/runs/39665585560/job/119457930294

Related Issue

Related to the failing refactor branch E2E run linked above.

Documentation PR

Not applicable; test-only change.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • I ran bun test
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

bun run build passed, and the staged-file lint and formatting hooks passed. The full format check was blocked by an unrelated local minimatch ESM/CommonJS dependency error. The targeted E2E run was attempted against the authenticated test account, but the local bundle failed before reaching these assertions with lib is not defined during CDK deployment; the referenced CI run completed deployment and failed only on the capitalization assertions corrected here.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly (not applicable)
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/xs PR size: XS label Oct 22, 2026
@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels Oct 22, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Oct 22, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 22, 2026
@jariy17
jariy17 merged commit bb0d5c3 into aws:refactor Oct 22, 2026
14 of 16 checks passed
@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 22, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Trivial follow-up to c9c8d851 fix(project): align user-facing copy style, which lowercased the deploy/teardown success messages (✔ deployed project '…' / ✔ removed project '…'). The three toContain assertions in e2eTest/project/harness.test.ts and e2eTest/project/templates.test.ts are updated to match the new casing — verified against src/handlers/project/buildDeploy.screen.test.tsx which uses the same lowercase strings. Nothing else to flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants