Skip to content

feat(aisix): declare upstream.media_fetch, upstream.bedrock and outbound.ssrf_protection in values.yaml - #409

Closed
jarvis9443 wants to merge 3 commits into
mainfrom
aisix/media-fetch-config
Closed

jarvis9443 wants to merge 3 commits into
mainfrom
aisix/media-fetch-config

Conversation

@jarvis9443

@jarvis9443 jarvis9443 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

This declares three new gateway startup settings in charts/aisix/values.yaml, each with the gateway's own default. They reach the config file through the ConfigMap the same way the rest of config does.

config:
  upstream:
    media_fetch:
      enabled: true
      max_bytes: 52428800
    bedrock:
      mantle_endpoint: null
  outbound:
    ssrf_protection:
      enabled: true
      allowed_hosts: []

upstream.media_fetch controls the media download. When the target upstream can't read a chat request's media URL itself, the gateway downloads it and sends the bytes inline. Pairs with api7/aisix#1314.

outbound.ssrf_protection is the product-wide SSRF setting for URLs supplied by an API caller that the gateway fetches, which today means only the media download. When it's on, those fetches reach only publicly routable addresses, and allowed_hosts is the exception list. enabled: false turns the check off. This replaces the earlier upstream.media_fetch.allowed_hosts, which was never released. Pairs with api7/aisix#1327.

upstream.bedrock.mantle_endpoint is the Bedrock Mantle base URL. When bedrock-runtime's CountTokens refuses a Claude model, /v1/messages/count_tokens falls back to it. Null derives https://bedrock-mantle.{region}.api.aws from the provider key's region; set it for a VPC endpoint or GovCloud. Pairs with api7/aisix#1318.

Hold this until the release that ships these changes. A gateway older than them refuses a config file that carries these keys.

🤖 Generated with Claude Code

Fixes api7/AISIX-Cloud#1885

@jarvis9443 jarvis9443 added the aisix-hold-for-release Gateway-key chart change: merges with the release that ships the key label Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Pairs with api7/aisix#1318: the Bedrock Mantle endpoint count_tokens
falls back to for Claude models bedrock-runtime cannot count. Null derives
https://bedrock-mantle.{region}.api.aws from the provider key's region.
…ed_hosts

The gateway moved the media download's allow-list to a product-wide
outbound.ssrf_protection block (enabled, allowed_hosts) in api7/aisix#1327.
@jarvis9443 jarvis9443 changed the title feat(aisix): declare upstream.media_fetch in values.yaml feat(aisix): declare upstream.media_fetch, upstream.bedrock and outbound.ssrf_protection in values.yaml Oct 21, 2026
jarvis9443 added a commit that referenced this pull request Oct 22, 2026
…nd.ssrf_protection

# Conflicts:
#	charts/aisix/README.md
@jarvis9443 jarvis9443 mentioned this pull request Oct 22, 2026
nic-6443 pushed a commit that referenced this pull request Oct 22, 2026
Both aisix charts move to version and appVersion 1.7.0. charts/aisix-cp is synced from AISIX-Cloud v1.7.0 (api.outbound.ssrfProtection replaces the four per-site private-address switches; checksum/secret pod annotations), preserving the public adaptations. charts/aisix folds #409 (upstream.media_fetch, upstream.bedrock.mantle_endpoint, outbound.ssrf_protection), #410 (Deployment metadata annotations) and #405 (drops the retired observability.usage_event.request_headers).

Co-authored-by: Jens Erat <628441+JensErat@users.noreply.github.com>
@jarvis9443

Copy link
Copy Markdown
Contributor Author

Folded into the 1.7.0 chart release in #408, which is now merged.

@jarvis9443 jarvis9443 closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aisix-hold-for-release Gateway-key chart change: merges with the release that ships the key

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant