Repository navigation
Feature/DIMS_v3.5_harmonize_NF - #136
Merged
Merged
Conversation
Jorisvansteenbrugge
requested changes
Oct 23, 2026
Jorisvansteenbrugge
left a comment
Jorisvansteenbrugge
left a comment
There was a problem hiding this comment.
Nice improvements!
- There were a few cases where
$params.references were still present in the script block of modules. - And I made a few suggestions.
Comment on lines
+21
to
+22
| $params.ppm \ | ||
| $params.zscore |
There was a problem hiding this comment.
Suggested change
| $params.ppm \ | |
| $params.zscore | |
| $ppm \ | |
| $zscore |
Comment on lines
+27
to
+34
| Rscript ${baseDir}/CustomModules/DIMS/EvaluateTics.R \ | ||
| $init_file \ | ||
| $params.nr_replicates \ | ||
| $analysis_id \ | ||
| $params.matrix \ | ||
| $highest_mz_file \ | ||
| $trim_params_file \ | ||
| $preprocessing_scripts_dir |
There was a problem hiding this comment.
Suggested change
| Rscript ${baseDir}/CustomModules/DIMS/EvaluateTics.R \ | |
| $init_file \ | |
| $params.nr_replicates \ | |
| $analysis_id \ | |
| $params.matrix \ | |
| $highest_mz_file \ | |
| $trim_params_file \ | |
| $preprocessing_scripts_dir | |
| Rscript ${baseDir}/CustomModules/DIMS/EvaluateTics.R \ | |
| $init_file \ | |
| $nr_replicates \ | |
| $analysis_id \ | |
| $matrix \ | |
| $highest_mz_file \ | |
| $trim_params_file \ | |
| $preprocessing_scripts_dir |
Jorisvansteenbrugge
previously approved these changes
Oct 23, 2026
Jorisvansteenbrugge
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified Nextflow scripts per step of the pipeline. All input parameters are now given as channels, consistent with
UMCUGenetics/DIMS#139
Styling modified for Rscript statements, all parameters now given on a separate line.