bugfix(horde): Prevent dead units from being considered for horde membership - #3067
Open
Stubbjax wants to merge 1 commit into
Open
bugfix(horde): Prevent dead units from being considered for horde membership#3067Stubbjax wants to merge 1 commit into
Stubbjax wants to merge 1 commit into
Conversation
Stubbjax
added
Bug
Caball009
reviewed
Aug 6, 2026
Stubbjax
force-pushed
the
fix-dead-horders
branch
from
August 6, 2026 14:41
d377829 to
ffd61db
Compare
|
Has there been a discussion if this change is desirable? I've no objections FWIW. |
xezon
approved these changes
Aug 6, 2026
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Code correct.
I agree this probably needs a vote, even if it is just a formality. It is a good nerf for Infantry General.
xezon
changed the title
|
Vote was created here: https://github.com/GeneralsZeroHour/GameDesign-Private/discussions/92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents dead units from being considered for horde membership.
Before
The horde bonus remains active until the dead Tank Hunter fully sinks into the ground and disappears
BEFORE.mp4
After
The horde bonus is lost as soon as the Tank Hunter dies
AFTER.mp4