refactor(player): Use slot indices for player conversions

[CryoTheRenegade]

Replaces the remaining player-index-to-slot-index reconstruction with PlayerList::getSlotIndex.
Update GameLogic::onLogicCrc, RecorderClass::handleCRCMessage, and VictoryConditions::update.

Related: #2897
Merge before #3034

[greptile-apps]

Greptile Summary

Replaces ad hoc player-name reconstruction with the centralized player-index-to-slot-index mapping.

• Uses slot indices for multiplayer CRC connectivity checks.
• Uses slot indices when matching replay CRCs to the local player.
• Uses slot indices when recording defeated AI players’ final frame in both game targets.

Confidence Score: 5/5

The PR appears safe to merge with no concrete correctness or security failures identified.

The changed paths consistently convert game-layer player indices through PlayerList’s slot mapping before consuming APIs and metadata expressed in the network-slot domain, while retaining invalid-slot and null guards.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp	Converts the CRC message sender’s player index to the network slot domain before checking connectivity.
Generals/Code/GameEngine/Source/Common/Recorder.cpp	Compares the converted sender slot with the replay header’s local slot instead of reconstructing player identity from a name key.
Generals/Code/GameEngine/Source/GameLogic/ScriptEngine/VictoryConditions.cpp	Resolves defeated AI players through PlayerList’s established slot mapping before updating slot metadata.
GeneralsMD/Code/GameEngine/Source/Common/Recorder.cpp	Mirrors the domain-correct replay CRC player-to-slot conversion for Zero Hour.
GeneralsMD/Code/GameEngine/Source/GameLogic/ScriptEngine/VictoryConditions.cpp	Mirrors the defeated-AI slot lookup update for Zero Hour.

_{Reviews (1): Last reviewed commit: "refactor(player): Use slot indices for p..." | Re-trigger Greptile}

[Skyaero42]

Is 2987 related, or does it actually resolve it? If it doesnt resolve it, what (part) of it does it solve?

[CryoTheRenegade]

If you mean #2897, #3033 resolves part 1: the player-index-to-slot-index conversions in onLogicCrc, handleCRCMessage, and VictoryConditions::update. It does not cover part 2, the reverse slot-index-to-player lookups; #3034 handles those. #2987 itself is unrelated.

[xezon]

Code can be simplified more.