Skip to content

chore(deps): apply npm group update, hold TypeScript at 5.x - #90

Merged
vpetersson merged 1 commit into
mainfrom
deps/npm-group-hold-typescript-5
Oct 6, 2026
Merged

vpetersson merged 1 commit into
mainfrom
deps/npm-group-hold-typescript-5

Conversation

@vpetersson-bot

Copy link
Copy Markdown
Contributor

Dependabot PR #87 fails all four CI jobs. Its grouped npm update bumps TypeScript to 7.0.2, and npm ci aborts before any job body runs:

npm error ERESOLVE could not resolve
npm error While resolving: typescript-eslint@8.70.0
npm error Found: typescript@7.0.2
npm error peer typescript@">=4.8.4 <6.1.0" from typescript-eslint@8.70.0

typescript-eslint 8.x has not declared TypeScript 7 support, so Lint, Format, Build and Test all fail at install time rather than on anything in the code.

What this does

  • Applies every dependency in the group except TypeScript.
  • Keeps TypeScript on 5.x.
  • Adds a Dependabot ignore entry for typescript >=7 so the same broken update is not reproposed every week.

Remove the ignore entry and take TypeScript 7 once typescript-eslint supports it.

Worth a look before merging

This group also carries @sentry/browser 10.59.0 → 11.0.0, a major release. src/utils/sentry.ts only uses init, setTag, setUser, setContext, captureException and a beforeSend hook, all of which are unchanged in v11, and it sets tracesSampleRate: 0 so the new span-streaming defaults do not apply. The one thing worth a deliberate decision is v11's more permissive default data collection — beforeSend here scrubs secrets from settings, but it does not control what the SDK attaches by default. Confirm that is acceptable, or pin @sentry/browser to ^10 in this PR.

It also carries vitest 4 → 5 and globals 13 → 17, both majors. The suite passes on them locally.

Verification

npm ci, npm run lint, type-check, test, build and format:check all pass locally on this branch.

Supersedes #87.

🤖 Generated with Claude Code

Dependabot's grouped npm update bumps TypeScript to 7.0.2, which makes
`npm ci` fail with ERESOLVE before any job can run:

    npm error peer typescript@">=4.8.4 <6.1.0" from typescript-eslint@8.70.0
    npm error Conflicting peer dependency: typescript@6.0.3

typescript-eslint 8.x has not declared TypeScript 7 support, so Lint,
Format, Build and Test all fail at install time.

This applies every other dependency in the group and keeps TypeScript on
5.x, and adds a Dependabot `ignore` entry for `typescript >=7` so the
break is not reproposed each week. Drop that entry once typescript-eslint
declares TypeScript 7 support.

Verified locally: `npm ci`, `lint`, `type-check`, `test`, `build` and
`format:check` all pass.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vpetersson
vpetersson merged commit 279ed96 into main Oct 6, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants