Repository navigation
chore(deps): hold TypeScript major bumps until typescript-eslint supports them - #88
Closed
vpetersson-bot wants to merge 1 commit into
Closed
vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
…orts them
typescript-eslint 8.x declares peer typescript '>=4.8.4 <6.1.0', and no
released version accepts anything newer. It is the parser behind
`edge-apps-scripts lint`, so a major TypeScript bump breaks two ways:
- here, `npm ci` fails with ERESOLVE (peer typescript vs typescript@7)
- in every edge app that installs @screenly/edge-apps, lint dies with
`TypeError: Cannot read properties of undefined (reading 'Cjs')`
Because the npm updates are grouped, one unmergeable TypeScript major also
holds back every other bump in the group. Ignoring only major TypeScript
updates lets the rest of the group land; minors and patches are unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: multica-agent <github@multica.ai>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scoped rule addresses the compatibility issue without blocking minor or patch updates.
Review effort: Lite
Findings: None
What changed in this PR
Defers Dependabot TypeScript major updates until typescript-eslint supports them, while preserving minor and patch updates.
Changes:
- Ignores
typescriptsemver-major updates. - Keeps minor and patch updates enabled.
| File | Description |
|---|---|
.github/dependabot.yml |
Adds the TypeScript major-version ignore rule. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 26, 2026
chore(deps): hold TypeScript major bumps until typescript-eslint supports them
Screenly/clock-app#21
Closed
Contributor
Author
|
Superseded by #90, which carries this same Dependabot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Tells Dependabot to skip major TypeScript bumps in the npm group. Minors and patches are unaffected.
Why it is wrong today
typescript-eslint8.x — the parser behindedge-apps-scripts lint— declares:There is no published
typescript-eslintrelease that accepts anything newer (latest is 8.70.1, same range). So every major TypeScript bump is unmergeable by construction, in two different shapes:Here,
npm cihard-fails:That is what all four checks on chore(deps): bump the npm group across 1 directory with 18 updates #87 are failing on.
In the edge apps that install
@screenly/edge-apps, Bun resolves it anyway and lint crashes at runtime:Because npm updates here are grouped under a single
'*'pattern, one unmergeable TypeScript major also blocks every other bump riding in the same PR.How I know the change is right
typescript-eslint8.57.0 → 8.70.1; all of them cap at<6.1.0.ignorewithupdate-types: [version-update:semver-major]is scoped to majors only, so security and minor/patch updates for TypeScript still come through.The same
ignoreblock belongs in the edge apps' owndependabot.ymlfiles — they each declaretypescriptdirectly and are each sitting on a red bun-group PR for this reason. Happy to follow up with those once this lands.🤖 Generated with Claude Code