Ecs Modify Component Pt 1 - #3588
Open
Crepestrom wants to merge 10 commits into
Open
Crepestrom wants to merge 10 commits into
Crepestrom wants to merge 10 commits into
Conversation
Crepestrom
marked this pull request as ready for review
September 8, 2026 19:40
Wunka
suggested changes
Sep 17, 2026
Comment on lines
-92
to
-99
| pub fn addToGroup(entity: Entity, group: main.server.permission.Group) void { | ||
| (getPermissionGroups(entity) orelse return).put(main.globalAllocator.allocator, group, {}) catch unreachable; | ||
| } | ||
|
|
||
| pub fn removeFromGroup(entity: Entity, group: main.server.permission.Group) bool { | ||
| return getPermissionGroups(entity).?.remove(group); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
you removed the changes from #3332 ?
Please fix this. Also as you already know the ECS is currently in flux.
So while I will put this into low priority (another reason is that we soon reaching the 0.4.0 release, so big changes are not that much accepted now), please make a comment about your plan with for example your part 2 so we can correctly evaluate if this the direction we want to go.
Contributor
Author
There was a problem hiding this comment.
Oops
Also that’s fine if I have to wait for the next version
I will write up a plan later
Contributor
Author
There was a problem hiding this comment.
wrote the thing on it
Contributor
Author
There was a problem hiding this comment.
also i fixed this thing now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the basic functions required for the Modify Component Ecs pt 2
meant for sending signals from the server to the client or the client to the server
modifyComponent
is meant for smaller signals that dont overwrite a entire component. (eg: sending how much damage a player takes, or sending a inventory command)