Skip to content

Fix: disabling WebAuthn 404s — DELETE /2factor/authn is not registered #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palmoni5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: disabling WebAuthn 404s — DELETE /2factor/authn is not registered #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions library.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ plugin.addRoutes = async ({ router, middleware, helpers }) => {
helpers.formatApiResponse(200, res);
});

routeHelpers.setupApiRoute(router, 'delete', '/2factor/authn', middlewares, async (req, res) => {
await plugin.removeAllDevices(req.uid);
helpers.formatApiResponse(200, res);
});

routeHelpers.setupApiRoute(router, 'post', '/2factor/authn/register', middlewares, async (req, res) => {
const attestationExpectations = {
challenge: req.session.registrationRequest.challenge,
Expand Down Expand Up @@ -392,6 +397,10 @@ plugin.disassociate = async (uid) => {
]);

// Clear U2F keys
await plugin.removeAllDevices(uid);
};

plugin.removeAllDevices = async (uid) => {
const keyIds = await db.getObjectKeys(`2factor:webauthn:${uid}`);
await db.sortedSetRemove('2factor:webauthn:counters', keyIds);
await db.delete(`2factor:webauthn:${uid}`);
Expand Down