Fix: disabling WebAuthn 404s — DELETE /2factor/authn is not registered - #125
Open
palmoni5 wants to merge 1 commit into
Open
Fix: disabling WebAuthn 404s — DELETE /2factor/authn is not registered#125palmoni5 wants to merge 1 commit into
palmoni5 wants to merge 1 commit into
Conversation
The 'Disable' button on the account 2factor page calls DELETE /api/v3/plugins/2factor/authn, but no such route was registered, so the request 404'd and users could not remove WebAuthn wholesale. Add the route, backed by a removeAllDevices helper that disassociate() now reuses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Disable button on the account 2factor page (
static/templates/account/2factor.tpl,data-action="disableAuthn") callsapi.del('/plugins/2factor/authn'), but only/2factor/authn/register,/devices,/device,/device/:idand/verifyare registered — there is no bareDELETE /2factor/authn. The request 404s and users cannot remove WebAuthn wholesale.This registers the missing route, backed by a new
plugin.removeAllDevices(uid)helper that clears all WebAuthn keys, their names, and their counters for the user.plugin.disassociatepreviously inlined the same key-clearing logic and now reuses the helper.