Repository navigation
Fold guide and documentation sections by default - #809
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuses native disclosures and the existing fragment handler. The manual generator preserves heading nesting and existing fragment URLs, including navigation without JavaScript.
Closes #804
Evidence
false !== trueafter clicking a heading); the manual test failed (0 !== 50disclosures).After:
cd site && npm testpasses all 20 tests, including independent toggles, nested manual sections, deep links with and without JavaScript, and guide diagrams at 320–1280px.cargo checkand JavaScript syntax checks pass. The generated manual passesnpm run docs:check.cargo testsuite passes (two tests ignored).Test seams
/docs/and/how-it-works/pages in Chromium: initial overview, independent mouse/keyboard disclosure, fragment navigation (with and without JavaScript), and mobile/desktop reading.Review coverage
Independent Standards and Spec reviewers read all seven changed files, including generated
site/docs/index.html, againstmain. No changed files were left unread; no generated-output exclusions. Standards' optional duplicated-test-loop finding was addressed in639d2dcand confirmed resolved. Spec found no issues.Unaddressed findings
Standards
None.
Spec
None.
Security
None. Guidance-mode review of all seven changed files against pinned merge base
57648f84c63e695882f380c29bef4f34518a7ef6, including the shared script, Markdown source, generator, and supporting tests, found no introduced security findings. URL fragments select existing elements and open disclosures; the generator reads a fixed repository source.node generate-docs.mjs --checkandnode --test tests/docs.test.cjspassed fromsite/in an isolated, network-disabled sandbox. No source changes were required.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Static presentation changes can be reverted.
Blast Radius: site
Guide/manual disclosure controls, section navigation, and manual generation.
Built with codex · gpt-6.1-sol · high