Skip to content

Fold guide and documentation sections by default - #809

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-804
Oct 19, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-804

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

 /how-it-works/ and /docs/
-  Load every explanation in full
+  Load section headings folded closed
+  Unfold individual sections by mouse or keyboard
+  Reveal linked content, including nested manual sections

Reuses native disclosures and the existing fragment handler. The manual generator preserves heading nesting and existing fragment URLs, including navigation without JavaScript.

Closes #804

Evidence

  • Before: the new guide overview test failed (false !== true after clicking a heading); the manual test failed (0 !== 50 disclosures).
    After: cd site && npm test passes all 20 tests, including independent toggles, nested manual sections, deep links with and without JavaScript, and guide diagrams at 320–1280px.
  • cargo check and JavaScript syntax checks pass. The generated manual passes npm run docs:check.
  • The full cargo test suite passes (two tests ignored).

Test seams

  • Rendered static /docs/ and /how-it-works/ pages in Chromium: initial overview, independent mouse/keyboard disclosure, fragment navigation (with and without JavaScript), and mobile/desktop reading.

Review coverage

Independent Standards and Spec reviewers read all seven changed files, including generated site/docs/index.html, against main. No changed files were left unread; no generated-output exclusions. Standards' optional duplicated-test-loop finding was addressed in 639d2dc and confirmed resolved. Spec found no issues.

Unaddressed findings

Standards

None.

Spec

None.

Security

None. Guidance-mode review of all seven changed files against pinned merge base 57648f84c63e695882f380c29bef4f34518a7ef6, including the shared script, Markdown source, generator, and supporting tests, found no introduced security findings. URL fragments select existing elements and open disclosures; the generator reads a fixed repository source. node generate-docs.mjs --check and node --test tests/docs.test.cjs passed from site/ in an isolated, network-disabled sandbox. No source changes were required.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Static presentation changes can be reverted.

Blast Radius: site

Guide/manual disclosure controls, section navigation, and manual generation.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit fbdde94 into main Oct 19, 2026
7 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-804 branch October 19, 2026 13:27
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant