Repository navigation
Improve thirdshift.app SEO and search discovery - #808
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make thirdshift.app's four public pages easier to discover and identify in search and link previews.
The manual's metadata comes from its existing generator; the prompts page's changes are in its handwritten head. Clarify the homepage and prompts descriptions and the manual's search title. Preserve both implementations through the upstream reconciliation.
Closes #803
Evidence
After: All three pass with JavaScript disabled.
cd site && npm testpasses all 16 tests, including generated manual consistency.cargo check,cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test prompts_page(11 prompt checks), andpython3 -m unittest discover -s scripts -p 'test_*.py'pass.cargo testpasses. The final reconciliation changes only site files; the site suite and prompt-generation checks pass again after that merge.Seams tested
robots.txtandsitemap.xml: XML validity, four public URLs, reachable pages, and canonical agreement.Review coverage
Independent Standards and Spec reviews used
git diff main...HEAD, withmainat77ed4b40c6abf4a62c70397067605e36be13d771. Standards raised one minor duplication finding in the new tests, addressed in13422a7and confirmed resolved. Spec raised no findings. Both reviewers checked the final reconciliation atba2bbcband read all nine changed files, including the generated manual's changed HTML and its generator. Unread changed files: none. Generated-output exclusions: none.Security guidance review of
77ed4b40c6abf4a62c70397067605e36be13d771...ba2bbcb9d7b31c7c416ab8e2bcae9f428559656f: all nine changed files and supporting documentation/prompt generation, browser client, test-server, CI and static-publication code reviewed. Applied injection, browser, HTTP, discovery/data-disclosure and generated-input/release guidance, with the repository's documented trust boundaries and ADR-0015. No introduced Security findings. Source inspection only; no proof-of-concept candidate required execution. No source changes or test execution in this session.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Static metadata and crawler discovery files; reverting restores the previous site behavior.
Blast Radius: Site
Built with codex · gpt-6.1-sol · high
CI notes
RESULT: cancelled; the branch diff changes only site files, andsite-testpassed.