GLOWS L3e: Support repointing field for ancillary files - #196
Open
leowerneck wants to merge 2 commits into
Open
leowerneck wants to merge 2 commits into
leowerneck wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pinned dependency lacks the new API, and integration-test filename expectations remain outdated.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds repointing identifiers to GLOWS L3e ancillary filenames to prevent same-day upload collisions.
Changes:
- Forwards repointing numbers when generating four L3e ancillary paths.
- Updates unit-test filename expectations.
File summaries
| File | Description |
|---|---|
imap_l3_processing/glows/glows_processor.py |
Adds repointing to generated ancillary filenames. |
tests/glows/test_glows_processor.py |
Updates expected L3e ancillary paths. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leowerneck
force-pushed
the
3386-glows---handle-repoint-number-in-filenames
branch
from
September 14, 2026 19:47
03ddf01 to
83c51de
Compare
leowerneck
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126 (see related imap_processing:#3386 issue).
Summary
This PR adds repointing field to ancillary files, so that e.g.:
is now a valid ancillary file name.
This relies on the new
repointingargument added toAncillaryFilePath.generate_from_inputsinimap-data-access(link TBD).Changes
imap_l3_processing/glows/glows_processor.py: addedrepointing=repointingto theAncillaryFilePath.generate_from_inputs(...)call in all four L3e paths (process_l3e_lo,process_l3e_ul_sf,process_l3e_ul_hf,process_l3e_hi). Each function already receivedrepointing: int; this just forwards it.tests/glows/test_glows_processor.py: updated the four expected L3e filenames to include-repoint00020(the tests already run withrepointing = 20).Coordinated rollout
One of three coordinated PRs for imap_processing:#3386. This PR should be merged third (3/3):