Support repointing field for ancillary files - #353
Merged
leowerneck merged 2 commits intoSep 14, 2026
Merged
leowerneck merged 2 commits into
leowerneck merged 2 commits into
Conversation
…ly exclusive with end_date)
There was a problem hiding this comment.
🟡 Changes recommended
Filename-based CLI queries remain unusable, and integer repointing zero is incorrectly omitted.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds repointing-aware ancillary filenames to distinguish same-day GLOWS outputs.
Changes:
- Parses and generates optional
repointXXXXXfields. - Forwards repointing in CLI filename queries.
- Adds ancillary filename validation tests.
File summaries
| File | Description |
|---|---|
imap_data_access/file_validation.py |
Adds ancillary repointing support and validation. |
imap_data_access/cli.py |
Adds repointing to ancillary query parameters. |
tests/test_file_validation.py |
Tests parsing, generation, and invalid combinations. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Any objections to merging this? I need this one merged for tests to pass on the other 2 PRs. |
leowerneck
merged commit Sep 14, 2026
613470d
into
IMAP-Science-Operations-Center:main
16 checks passed
leowerneck
deleted the
3386-glows---handle-repoint-number-in-filenames
branch
September 14, 2026 16:24
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is required to close imap_processing:#3386 and imap_L3_processing:#126.
Summary
This PR adds repointing field to ancillary files, so that e.g.:
is now a valid ancillary file name.
The new ancillary file name grammar is:
with
<end_date>and<repointing>being optional and mutually exclusive.Changes
AncillaryFilePath(imap_data_access/file_validation.py)FILENAME_CONVENTIONand the class docstring document the new optional-repointNNNNNfield and its mutual exclusivity withend_date.extract_filename_componentsparses the repointing into anint(orNone). Theend_date/repointingpair is expressed as a single alternation group in the regex, so a filename carrying both is rejected as invalid rather than silently accepted.generate_from_inputsgained arepointing: int | str | None = Noneargument (accepts12345or"repoint12345"), appended last to stay positional-compatible. It raisesInvalidImapFileErrorif bothend_timeandrepointingare supplied, matching the existing CR/repointing guard on the science generator.validate_filenamereports a non-integer repointing (parity with the science validator).cli.py: the ancillary--filenamequery dict now includesrepointing.tests/test_file_validation.py): addedtest_ancillary_file_path_repointing: int and"repointXXXXX"parsing, round-trip generation +construct_path, mutual-exclusivity rejection (both in the parser and the generator), and malformed-repointing rejection.Coordinated rollout
One of three coordinated PRs for imap_processing:#3386. This PR should be merged first (1/3):