48278 - Scoring adjustment crashes with a TypeError when a participant has no pass result - #12028
Open
lorenzgith wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
A note on the second commit: PHP-CS-Fixer failed on this file, but not because of the change itself.
Happy to drop it into a separate PR if you would rather keep this one strictly to the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mantis.ilias.de/view.php?id=48278
Saving a change in the scoring adjustment of a question aborts with a TypeError:
The query behind this data selects
FROM tst_activeand joinstst_pass_resultwith aLEFT JOIN, so a participant who has an active id but no pass result produces a row wherepassisNULL.getCorrectionsEvaluationData()passes that straight intoaddPass(int $pass_nr, ...).The sibling method
getEvaluationData()in the same class already guards against exactly this. This adds the same guard, so both methods behave consistently.Effect: the scoring adjustment is unusable in any test that contains a participant without a finished attempt, which is common right after an exam.