Test 45782: Prevent manual scoring of unfinished attempts - #11509
Test 45782: Prevent manual scoring of unfinished attempts#11509matheuszych wants to merge 2 commits into
Conversation
matheuszych
changed the title
|
@kergomard please review! |
|
Possibly I am just mistaken – but I fail to see the direct connection of this PR to the mentioned issue, implied by the Mantis link. 🤔 (... just in case this remark has any relevance at all 😉) |
kergomard
left a comment
kergomard
left a comment
There was a problem hiding this comment.
Thank you very much for the PR @matheuszych
First: I would echo the comment from @jweber-unibe : Could you tell me what problem you are trying to solve and where the corresponding behavior is specified? A link to an issue where @dsstrassner agreed that this is the right way to go, would completely suffice.
Then:
- This looks potentially unnecessarily expensive we somehow retrieve a whole dataset to get one single small information and simply rely on the fact that it will be cached. If we think we need this information: Shouldn't it be available in a dataset we will really need at these points?
- This will look completely different for ILIAS 11, though, right? Could you please provide a PR for ILIAS 11. If this PR can be made more elegant, we can stick to the solution here for ILIAS 10 as we would have an immediate exit ramp.
Thank you very much again and best,
@kergomard
See: https://mantis.ilias.de/view.php?id=45782 Manual scoring by question allowed opening the scoring UI for attempts that were still in progress. `ScoringByQuestionTableBinder` now skips unfinished attempts when composing table rows. `TestScoringByQuestionGUI` verifies the attempt is finished via `getAttemptOverviewFor` before calling `getAnswerDetail`; otherwise an exception is thrown.
See: https://mantis.ilias.de/view.php?id=45782 The test participants listing always summarized attempt overview data for scored attempts only. `ParticipantTable` now renders a UI mode control (scored attempts vs last attempts), keeps the choice in the `view_mode` request parameter via `RequestDataCollector::getViewMode()`, and passes `ilCtrl` into the table for proper link targets. `Results\Data\Factory::addAttemptOverviewInformationToParticipants` accepts a flag to target the last started pass when building overviews. English and German assessment language entries cover the new labels.
|
@kergomard & @matheuszych I think @matheuszych should report about this in the TechSquad. |
|
Relating to my comment from above (Apr 30) ...
→ Possibly this PR was rather meant to point to https://mantis.ilias.de/view.php?id=44871?! (Maybe(?!) also of interest in this context: https://mantis.ilias.de/view.php?id=48278 / #12028) |
5 participants
See: https://mantis.ilias.de/view.php?id=45782
Manual scoring by question allowed opening the scoring UI for attempts that were still in progress.
ScoringByQuestionTableBindernow skips unfinished attempts when composing table rows.TestScoringByQuestionGUIverifies the attempt is finished viagetAttemptOverviewForbefore callinggetAnswerDetail; otherwise an exception is thrown./cc @thojou