Repository navigation
Repair the build after the file rearrangement - #4
Merged
Merged
Conversation
Moving race_dashboard into primary/ left two includes pointing at the old layout, so main has not built since. Every CI job has been red on it. src/telemetry_source.h still asked for "race_dashboard.h", which no longer resolved from src/, and src/main.c was changed to reach up with "../primary/race_dashboard.h", which works but bakes the current layout into the include and breaks again on the next move. Both source directories are now on the target's include path, so headers refer to each other by name and neither file cares where the other lives. The warnings job had the same problem in a different form: it compiled a hardcoded list of files, which quietly stopped covering race_dashboard.c the moment it moved. It now discovers sources, and fails if it finds none. Also trims the comments in telemetry_source, which ran to 58% of the header with blocks of 18 and 13 lines restating the PR description.
taciturnaxolotl
force-pushed
the
fix/build-after-restructure
branch
from
September 26, 2026 15:13
ae81dca to
7ae9104
Compare
taciturnaxolotl
added a commit
that referenced
this pull request
Sep 26, 2026
Moving race_dashboard into primary/ left two includes pointing at the old layout, so main has not built since. Every CI job has been red on it. src/telemetry_source.h still asked for "race_dashboard.h", which no longer resolved from src/, and src/main.c was changed to reach up with "../primary/race_dashboard.h", which works but bakes the current layout into the include and breaks again on the next move. Both source directories are now on the target's include path, so headers refer to each other by name and neither file cares where the other lives. The warnings job had the same problem in a different form: it compiled a hardcoded list of files, which quietly stopped covering race_dashboard.c the moment it moved. It now discovers sources, and fails if it finds none. Also trims the comments in telemetry_source, which ran to 58% of the header with blocks of 18 and 13 lines restating the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving
race_dashboard.{c,h}intoprimary/left two includes pointing at the old layout:The fix
Both source directories go on the target's include path:
Headers then refer to each other by name and neither file cares where the other lives.
../primary/inmain.creverts to a plain#include "race_dashboard.h".