Repository navigation
Cut the comments back in telemetry_source - #5
Closed
taciturnaxolotl wants to merge 1 commit into
Closed
taciturnaxolotl wants to merge 1 commit into
taciturnaxolotl wants to merge 1 commit into
Conversation
58% of the header was comment, with blocks of 18 and 13 lines restating what the PR description already said. Trimmed to what changes a decision: the channel map is code rather than config and why, the fallback behaviour, and why two indicators stay deliberately unmapped.
Contributor
Author
|
Folding into #4 rather than stacking another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behaviour change. Stacked on #4, because
maindoes not currently compile without it.58% of
telemetry_source.hwas comment, with blocks of 18 and 13 lines restating what the PR description already said.Trimmed to what actually changes a decision:
git pullengine_armedandengine_onstay deliberately unmappedAll four sources still compile with
-Wall -Wextra -Werror, both build modes clean.