Skip to content

Fix release docs checkout trust #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuecideng merged 1 commit into from
Sep 24, 2026
+19 −0
Merged

Fix release docs checkout trust #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/docs-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ jobs:
ref: ${{ github.event_name == 'release' && github.event.release.tag_name || inputs.ref != '' && inputs.ref || 'main' }}
- uses: ./.github/actions/activate-conda

- name: Trust checked-out repository
shell: bash
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"

- name: Restore full multi-version docs site
uses: actions/cache/restore@v4
with:
Expand Down
15 changes: 15 additions & 0 deletions tests/ci/test_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,18 @@ def test_automatic_pages_deployment_requires_existing_docs_artifact() -> None:
assert deploy_condition.startswith("always() &&")
assert "needs.inspect-docs-artifact.outputs.exists == 'true'" in deploy_condition
assert "inputs.artifact_run_id != ''" in deploy_condition


def test_manual_docs_build_trusts_checkout_before_architecture_generation() -> None:
jobs = _load_workflow("docs-pages.yml")["jobs"]
steps = jobs["build-and-deploy"]["steps"]
step_names = [step.get("name", "") for step in steps]

trust_index = step_names.index("Trust checked-out repository")
build_index = step_names.index("Build docs site")
trust_command = steps[trust_index]["run"]

assert trust_index < build_index
assert (
'git config --global --add safe.directory "$GITHUB_WORKSPACE"' in trust_command
)
Loading