Add tianji marvin | Fix solver tcp inversion - #686
Conversation
|
| raise TypeError("with_gripper must be a boolean.") | ||
|
|
||
| self.uid = "TianjiMarvin" | ||
| self.fpath = self._pk_urdf_path |
There was a problem hiding this comment.
Local overrides trigger downloads
If a caller supplies a local fpath on a machine without the Tianji Marvin asset cached, this line resolves the default asset before the override is applied. That starts a download, so configuration creation fails offline even though the caller provided a usable local URDF. Resolve the default asset only when no path override was supplied.
Knowledge Base Used: Asset and dataset management
Prompt To Fix With AI
This is a comment left during a code review.
Path: embodichain/lab/sim/robots/tianji_marvin.py
Line: 99
Comment:
**Local overrides trigger downloads**
If a caller supplies a local `fpath` on a machine without the Tianji Marvin asset cached, this line resolves the default asset before the override is applied. That starts a download, so configuration creation fails offline even though the caller provided a usable local URDF. Resolve the default asset only when no path override was supplied.
**Knowledge Base Used:** [Asset and dataset management](https://app.greptile.com/dexforce/-/custom-context/knowledge-base/dexforce/embodichain/-/docs/asset-data-management.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| raise TypeError("with_gripper must be a boolean.") | ||
|
|
||
| self.uid = "TianjiMarvin" | ||
| self.fpath = self._pk_urdf_path |
There was a problem hiding this comment.
If someone changes with_gripper in a saved configuration but keeps its serialized fpath, the merge restores the old variant’s URDF after this method selects control parts and solver frames for the new variant. Simulation then loads a model that does not match those controls and FK/IK frames. Reconcile the asset path with the selected variant when rebuilding the configuration.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: embodichain/lab/sim/robots/tianji_marvin.py
Line: 99
Comment:
**Variant can load wrong URDF**
If someone changes `with_gripper` in a saved configuration but keeps its serialized `fpath`, the merge restores the old variant’s URDF after this method selects control parts and solver frames for the new variant. Simulation then loads a model that does not match those controls and FK/IK frames. Reconcile the asset path with the selected variant when rebuilding the configuration.
**Knowledge Base Used:**
- [Simulation lab](https://app.greptile.com/dexforce/-/custom-context/knowledge-base/dexforce/embodichain/-/docs/simulation-lab.md)
- [Motion planning and kinematics](https://app.greptile.com/dexforce/-/custom-context/knowledge-base/dexforce/embodichain/-/docs/motion-planning-and-kinematics.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Description
embodichain/lab/sim/robots/tianji_marvin.pyPytorchSolverget_iktcp pose inversion error.Type of change
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py), if applicable