Repository navigation
Compute slot items once per render instead of once per slot - #613
Merged
Merged
Conversation
|
markfee
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #612
Every
SlotRendererused to callgetSlotItems, which ran everyexcludeWhenacross all buttons and controls before keeping its own slot's items. Slot items are now built once per render bygetItemsBySlotand shared with every slot through a newSlotItemsProvideraround<Layout />. This cuts repeated checks by about 15×, so the cost grows with the number of items rather than slots × items. Behaviour and the number of renders are unchanged. Reducing renders, for example with a stateMap, will be explored in a follow-up ticket.