Repository navigation
Fix docs examples crashing on exclusiveSlot by compiling iterable spread correctly - #617
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #613, every example on the docs site has crashed with
Cannot read properties of undefined (reading 'exclusiveSlot'). Docusaurus compiles the map's source with loose Babel, which turns[...map.values()]into[].concat(map.values()), an array holding the iterator instead of its values. This adds a customjsLoaderthat keeps the Docusaurus defaults but setsiterableIsArray: falseforsrc,pluginsandproviders, and adds@docusaurus/babelas a dev dependency. It also fixes two existing Sonar and type warnings in the config. The package builds and tests don't use this config, so they aren't affected.