Skip to content

585 layers button no menu - #611

Merged
dannyleech merged 6 commits into
mainfrom
585-layers-button-no-menu
Oct 20, 2026
Merged

dannyleech merged 6 commits into
mainfrom
585-layers-button-no-menu

Conversation

@dannyleech

Copy link
Copy Markdown
Contributor

Fixes #585

The Layers button is now left out with excludeWhen when there's no layers menu, instead of being hidden while its panel is removed. That removed panel is what WAVE flagged as a broken ARIA reference.

  • Before the datasets load, the button is shown or left out based on the config's showInMenu. After they load, it follows the live menu, so it appears and disappears as datasets are added and removed at runtime.
  • The panel stays registered. If the menu empties while the panel is open, the panel closes, and focus moves to the map only if it was in the panel.

Builds on #597 by @zaid3. Thanks!

Co-authored-by: A Haque 40199643+zaid3@users.noreply.github.com

@dannyleech
dannyleech requested a review from markfee October 20, 2026 13:58
@dannyleech

Copy link
Copy Markdown
Contributor Author

Updated so that hasMenu: false now leaves the Layers button and panel out completely, rather than just hiding the button.

@sonarqubecloud

Copy link
Copy Markdown

@dannyleech
dannyleech merged commit d0e3e25 into main Oct 20, 2026
2 checks passed
@dannyleech
dannyleech deleted the 585-layers-button-no-menu branch October 20, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't render the datasets Layers button when there's no layers menu

3 participants