Repository navigation
642 Move panel-close focus handling and the map size scale into core - #643
Merged
Merged
Conversation
|
markfee
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Resolves #642
Reduces what plugins import from core, ahead of the packaging work (#592).
Panel focus
hidePanel()/APP_HIDE_PANELnow moves focus the same way as closing a panel with its close button: to the element that opened it if it's still on the page, otherwise to the map. If focus was outside the panel, it stays where it is.hidePanelshare the newfocusAfterPanelCloseutil.getPanelElementId.Map size scale
mapState.mapSizeScalegives the scale for the current map size.MapProviderworks it out frommapSize, so it isn't stored separately.Markersuse it instead of looking upscaleFactor[mapSize].scaleFactorfrommapSizeScales.js, so no plugin importsappConfig.jsany more.Also
aria-hidden). The button text already names it. This fixes a Sonar warning.hidePanelnow says how it moves focus, andmapState.mapSizeScaleis documented.