Build only libs when the core is a subproject - #38
Merged
Merged
Conversation
astronomerdave
requested review from
mikelangmayr,
prkrtg and
scizen9
as code owners
September 28, 2026 21:23
fc8bf34d was removed from the instrument repo, so checking out submodules fails and every workflow that does so has been failing on main since PR#37. 60382fd is the head of the instrument repo's main.
Contributor
Author
|
*** see edited description *** Now that instrument repos are private, CIs will fail now until I finish removing the submodules. |
prkrtg
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now decides what the core builds when another project composes it, per the discussion in PR #37. As a subproject it now provides its libraries only. Top-level builds are unchanged.
I increased the min cmake version from 3.12 to 3.24, needed to support subproject design (well, at least 3.21 is needed for
PROJET_IS_TOP_LEVEL).I removed OpenCV. Currently only NIRC2 is using it and I'd like to try to move forward without it (I made that decision in a hurry based on tools I knew how to use, and there may be better options).
New CI builds the core and a subproject consumer.
CI jobs that check out submodules fail because two of the instrument repos (cryoscope, hispec-tracking-camera) are private; that will be fixed soon. The last commit moves the hispec_tracking_camera pin to 60382fd, since fc8bf34d no longer exists in that repo; if this is squash-merged, please keep that in the message.