server receives its interface, the daemon's child calls create() - #41
Merged
Merged
Conversation
astronomerdave
requested review from
mikelangmayr,
prkrtg and
scizen9
as code owners
September 29, 2026 18:01
mikelangmayr
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required to meet camera 2.0 design
The
Serverno longer creates its own interface. The daemon's child process callsCamera::Interface::create()and hand the result to theServerconstructor. This keeps the server independent of how the interface is made, so the interface, server and daemon stay separable modules. The Python module already gets its interface fromcreate()with no server or daemon.CI jobs that check submodules will continue to fail (see PR #38) for now.