Install the binaries to a prefix instead of running from the build tree - #23
Merged
Merged
Conversation
mikelangmayr
requested review from
astronomerdave,
prkrtg and
scizen9
as code owners
September 15, 2026 22:18
mikelangmayr
force-pushed
the
mike/install-rules
branch
from
September 15, 2026 23:03
100920c to
2722017
Compare
prkrtg
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install()rules somake installcopies build outputs under${CMAKE_INSTALL_PREFIX}(defaults to/usr/local) instead of running them frombin/in the source treeGNUInstallDirsat the top level forCMAKE_INSTALL_BINDIRandCMAKE_INSTALL_LIBDIRcamerad-emulator,camerad-socksendandcamerad-shm-reader, sinceemulatorandsocksendare too generic for a directory shared with every other package.cameradkeeps its namecamera_interfacePython module tolib, so it has a stable path to put onPYTHONPATHlistener: nothing incamerad/orcommon/usesUdpSocket, so it has no producer to listen tomake installin CI: the python-module job now builds everything, installs to a prefix, checks all four binaries are present and executable, and imports the module from the prefix with the build tree offPYTHONPATHso a missing install rule cannot pass silentlyopen,load,power on,exptime 0,expose 1against the emulator with only the installed binaries onPATH, all returningDONE, and by confirming the CI import assertion fails when pointed at the build tree