Install the Python module and binaries with pip - #24
Merged
Merged
Conversation
mikelangmayr
requested review from
astronomerdave,
prkrtg and
scizen9
as code owners
September 16, 2026 17:03
prkrtg
approved these changes
Sep 16, 2026
mikelangmayr
force-pushed
the
mike/python-packaging
branch
from
September 16, 2026 18:54
cdfeb59 to
69f3ef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23, so the diff shows only the packaging work. Retarget to main once #23 merges.
pyproject.tomlusing scikit-build-core, sopip install ./camera-interfacecompilescamera_interfaceinto site-packages and putscameradand its tools on the environment'sPATH.CONTROLLERdefaults toarchonandBUILD_PYTHON_MODULEis forced on; any other CMake option passes through as--config-settings=cmake.define.X=Y[build-system] requires, so pip fetches it into an isolated build environment rather than the user installing it by handPROJECT_BASE_DIRfromCMAKE_CURRENT_SOURCE_DIRinstead of$ENV{PWD}/../. A build backend invokes cmake withcwd=, which does not updatePWD, so the old form failed the configure outright withadd_subdirectory given source "/tmp/..//camerad". Identical for the existingcd build && cmake ..flowSKBUILD_SCRIPTS_DIR/SKBUILD_PLATLIB_DIRunder a wheel build and to the GNU prefix layout otherwise, since a wheel needs the module importable as a top-level name and the binaries onPATHbin/pip installinto a scratch venv: the module imports from site-packages withPYTHONPATHunset and reportshispec_tracking_camera/archon, andopen,load,power on,expose 1all returnDONEagainst the emulator using only the venv's binaries