Skip to content

Fix runtime issue with renderer initialization #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Av3boy merged 3 commits into from
Sep 13, 2026
Merged

Fix runtime issue with renderer initialization #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
956bdb5
Fix runtime issue with renderer initialization
Sep 13, 2026
c5050af
Add ImGui to gitignore
Sep 13, 2026
2b5671b
Delete extra file
Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,3 +264,6 @@ __pycache__/
/Editor/shortcut.reg

.env

# Autogenerated ImGui configuration file
imgui.ini
11 changes: 11 additions & 0 deletions SharpEngine.Core/Renderers/Renderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,17 @@ public class Renderer : RendererBase
/// <inheritdoc />
public override RenderFlags RenderFlag => RenderFlags.Renderer3D;

/// <summary>
/// Initializes a new instance of <see cref="Renderer"/>.
/// </summary>
/// <param name="camera">The game the renderer is being used for.</param>
/// <param name="settings">The settings for the renderer.</param>
/// <param name="scene">The game scene to be rendered.</param>
public Renderer(CameraView camera, ISettings settings, Scene scene)
: this(camera, settings, scene, LoggerFactory.Create(builder => builder.AddConsole()).CreateLogger<Renderer>())
{
}

/// <summary>
/// Initializes a new instance of <see cref="Renderer"/>.
/// </summary>
Expand Down