test: prevent regression of hitting out stat aliases - #337
Closed
Mattsface wants to merge 1 commit into
Closed
Conversation
Member
Author
|
This is not needed. Stupid chat bots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds deterministic regression coverage for #246.
The underlying bug was already fixed by commit
f9273f4(fix/correct hitting stat aliases) and the corrected aliases are present in the currentv1.1.0release. Issue #246 remained open, however, and there was no focused offline test protecting the exact MLB payload keys that caused the regression.This PR verifies that
SimpleHittingSplitcorrectly consumes:flyOutsgroundOutsairOutsstrikeOutsgroundOutsToAiroutsIt also verifies the related advanced hitting aliases:
walkOffsflyOutspopOutslineOutsgroundOutsNo production behavior is changed; this locks in the already-released fix with deterministic coverage that does not depend on the live MLB API.
Refs #246