Repository navigation
bench: move VCU_Command to 0x101 (land #6 on main) - #8
Merged
Merged
Conversation
0x100 is the predefined COB-ID of the CANopen TIME object (CiA 301). can-full puts the VCU on a bus with a CANopen node, so a node that consumes TIME takes the VCU's command frames as TIME, and any CANopen tool decodes them as TIME. CiA 301 forbids CANopen devices from configuring 0x101-0x180, so a non-CANopen message there cannot collide with a CANopen node, and 0x101 keeps the command's bus priority essentially unchanged. bench-health matches the message by name, so it reads both live data and traces recorded before the move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #6 on main. #6 merged into its stack base
feat/canopen-hilafter #5 had already merged, so its three commits never reached main. Same commits, unchanged:bench: move VCU_Command to 0x101, off the CANopen TIME idcan-full: say why the VCU command is at 0x101canopen: drop the notes on the TIME collision, gone with the VCU moveReviewed and tested as #6: CI 14/14 (Renode benches incl. CANopen), and on hardware the example suites 26/26 with these images. The genset enters Drive on VCU_Command at 0x101 and sends its DM1.
zelos-can's
test/hil/nodes/bench.dbcalready expects 0x101 (zeloscloud/src#1628, merged), so main is out of step until this lands.