Repository navigation
CAN bench runs on the latest Zelos release, without its workarounds - #7
Merged
Merged
Conversation
Agent 26.0.8 -> 26.0.9, CLI 0.1.9 -> 0.1.10, and the notebooks pin zelos-sdk 0.0.12. Those releases fix what the bench was working around: - Rendered notebooks are no longer written 0600 and root-owned (zeloscloud/src#1505), so the `chmod a+r` step and the entrypoint's umask go. - `zelos extensions install` takes a version with or without its "v" (zeloscloud/src#1491), so that comment goes. 26.0.9 no longer binds `[::]`; it serves IPv4 with a warning. The default, 0.0.0.0:2300, is what the bench wants, so `--listen-address` goes. `just record`, the traces/ mount and traces/dcdc-defect.trz go too. They fed the first notebook suite, which checked a committed recording; the current two notebooks read the live bench, and nothing reads the recording. The apt source uses the signed keyring, as the install docs do, instead of [trusted=yes]. The README gets the versions, the Data view, and the CAN/<bus>/... signal layout the extension has published under since v0.1.15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CAN bench now runs on the current Zelos release: agent 26.0.9, CLI 0.1.10 and SDK 0.0.12. Everything it carried to work around older releases is gone. The two can-bench blog posts link to this code.
Rendered notebook pages came out unreadable, so the bench chmod-ed them as root. The same went for recorded traces, and the entrypoint set
umask 022in the belief that it was the cause.Cause. CLI 0.1.9 wrote its outputs mode 0600, owned by the container's root (zeloscloud/src#1505). The umask was never the cause.
Fix. CLI 0.1.10 writes them
0666 & umask. Thechmod a+rstep injust testand the entrypoint'sumaskgo. CI's artifact upload reads the pages as the runner user, so it proves the fix.The extension install needed its version spelled with a leading
v.Cause. CLI 0.1.9 matched the marketplace tag literally (zeloscloud/src#1491).
Fix. CLI 0.1.10 takes either spelling. The comment that warned about it goes.
Bumping the agent with
--listen-address '[::]:2300'would bind IPv4 only, with a warning.Cause. Agent 26.0.9 no longer binds
[::]. It falls back to0.0.0.0and warns.Fix. The flag goes. The default,
0.0.0.0:2300, is what the bench wants.just record, thetraces/mount andtraces/dcdc-defect.trzwere dead. They fed the first notebook suite, which checked a committed recording. Since96b2fdfthe two notebooks read the live bench, and nothing reads the recording.The apt source was
[trusted=yes]. The repository is signed now. The image uses the keyring andSigned-By, as the install docs do.The README described an older app and extension.
vcan0/...and avcan0_rawsource. Since extension v0.1.15 they publish underCAN/vcan0/..., with raw frames atCAN/vcan0/Frame.Versions
zelos-sdk[notebook]in both notebooks>=0.0.12a2==0.0.12Size
One commit. +22 / −46 lines across 7 files, plus the deleted 124 KB
dcdc-defect.trz. No tests change; the bench's tests are its two notebooks.Behavior changes for review
just recordis gone, with thetraces/mount and the committed recording.0.0.0.0:2300, its default. It no longer asks for[::].zelos-sdk[notebook]==0.0.12exactly, so a tagged checkout resolves the same SDK.tzdatastays in both notebooks. Removing it broke both in CI, withArrowInvalid: The zoneinfo module or pytz package must be installed. The SDK returns time-zone-aware timestamps, and neither it nor the agent image supplies the zone data.Rollout
The two can-bench blog posts (zeloscloud/src#1530) clone and link the
can-bench-v1tag. After this merges,can-bench-v1moves to the merge commit. The posts are not published yet, so nobody has cloned the old tag from them.Testing
can-benchCI one2364fe: run 37214292717, green in 5m41s.bench-healthpasses 8 of 8 checks, anddcdc-respects-allowancepasses 1 of 1, on the good build.test-resultsartifact uploads both rendered pages, with nochmod.can-fullCI one2364fe: run 37214292734, green.tzdata, failed both notebooks on missing zone data (run 37213553619). That run had already built the images, installed the extension and brought the bench up.just flash defect. CI reaches the agent from inside its container and runs only the good build.