Repository navigation
Conversation
main carries more than 4.0.0 (net10.0 build, Global\/Local\ region names, same-thread two-instance detection, Auto-layout fingerprint), so packing it under 4.0.0 would produce a package that differs from the 4.0.0 release at 4aec041. Release notes now describe 4.1.0. The README mentions 4.x instead of 4.0.0 where the statement holds for every 4.x version; the install line stays at 4.0.0 until 4.1.0 is published. The CHANGELOG section keeps "not released yet" and gets its date when the tag is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainstill says<Version>4.0.0</Version>, but it contains more than the 4.0.0 release (4aec041): thenet10.0build,Global\/Local\region names, same-thread two-instance detection and the Auto-layout fingerprint. A pack frommainwould produce a package named 4.0.0 that differs from the released one.InterprocessMemory.csproj:<Version>4.0.0 -> 4.1.0, andPackageReleaseNotesnow describe 4.1.0 (they described version 4 before).README.md: two statements that hold for every 4.x version say "4.x" instead of "4.0.0" (format version 3 is still written; 3.0.0 must not share a region with any 4.x version on Linux).Left as they are on purpose:
--version 4.0.0until 4.1.0 is published.4.1.0 (not released yet); it gets its date when the tag is created.Verification
437d1ceis green on Linux and Windows. The Linux pack step createdInterprocessMemory.4.1.0.nupkgand.snupkg(packageartifact, 182,491 bytes, about twice the net8.0-only 4.0.0 package). Both frameworks ran the tests.lib/net8.0andlib/net10.0), because the artifact download host is blocked from the environment that prepared this PR. Check it before publishing:unzip -l InterprocessMemory.4.1.0.nupkg | grep lib/.No code changes. Not tagged, not published.