Repository navigation
Refactor ActivityUtils into a non-static class - #52
Merged
Merged
Conversation
zHd4
commented
Sep 21, 2026
zHd4
commented
Owner
- Refactor ActivityUtils from static methods into an instance-based utility tied to an ActivityBase.
- Update activities and AuthHandler to use injected ActivityUtils instances for toasts, clipboard operations, and back-button handling.
- Adjust AuthHandler tests to mock and verify ActivityUtils interactions.
…cross activities * Convert `ActivityUtils` methods from static to instance methods and require an `ActivityBase` instance via constructor. * Instantiate and use `ActivityUtils` in `AuthActivity`, `ExportActivity`, `FileViewerActivityBase`, `ImportActivity`, `ImportKeyActivity`, `KeyRecoveryActivity`, `SecretsUpdateActivity`, `SetupKeyActivity`, and `StartActivity`. * Inject `ActivityUtils` into `AuthHandler` and update its `showToastMessage` implementation. * Update `AuthHandlerTest` to mock and verify `ActivityUtils` interactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.