Repository navigation
Pin the engine 3.51.0 tag and release 3.51.0.110 - #266
Merged
Merged
Conversation
The engine tagged 3.51.0 as b0972289, and its HTTRACK_VERSIONID reads "3.51.0", so the versionName prefix follows it and versionCode goes to 110. The tag adds two commits over the previous pin. Neither one adds or removes a source file, so Android.mk needs no change. The release notes keep their four bullets and take only the new version number. The login and Accept-headers story they tell has reached the internal track alone, so nobody on production has read it yet. Built both ABIs and ran the unit tests: 660 pass, none skipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
A semicolon joined two statements in the comment above versionName. The reader had to work out that the prefix and the fourth part make one string, so the comment now gives the format. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine's 3.51.0 tag is b0972289 and its HTTRACK_VERSIONID reads 3.51.0, so versionName takes that prefix and versionCode goes to 110. Neither of the two engine commits in the tag adds or removes a source file, so Android.mk is unchanged.
The release notes keep their bullets and only take the new number. The login and Accept-headers work they describe has gone no further than the internal track.