Repository navigation
Conversation
The engine refuses a framing header on -%X, refuses a line that names no header, and keeps only the last of Host, Cookie and Authorization. It says why with fprintf on stderr, which this app discards, so a header the user typed was silently never sent and nothing explained it. Leaving the Browser ID page now names each dropped line. The engine's two lists are copied here, which is the part that could rot, so the test reads them back out of the pinned engine source and compares. Changing the engine's own array turns it red, so a pin bump cannot move the list quietly. Asking the engine instead would have been better and is not available. http_custom_header_warning returns exactly this verdict, but it is declared inside #ifdef HTS_INTERNAL_BYTECODE and carries no HTSEXT_API, so it is neither visible to our translation unit nor exported from libhttrack for libhtslibjni to call. A JNI wrapper fails to compile. If the engine ever promotes it, this class should call it and drop the copy. A profile loaded from winprofile.ini never passes through this page, so its headers go unchecked. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine refuses some
-%Xheader lines. It drops a framing header it sets itself, a line that names no header, and all but the last ofHost,CookieandAuthorization. It explains each one withfprintfon stderr, which this app discards. So a header the user typed was never sent and nothing said why.Leaving the Browser ID page now names each dropped line.
The engine's two lists are copied here, which is the part that can rot. The test reads them back out of the pinned engine source and compares. Changing the engine's own array turns it red, so a pin bump cannot move the list quietly.
Asking the engine instead would be better and is not available.
http_custom_header_warningreturns exactly this verdict. But it sits inside#ifdef HTS_INTERNAL_BYTECODEand carries noHTSEXT_API, so our translation unit cannot see it andlibhttrackdoes not export it. A JNI wrapper fails to compile. If the engine promotes it, this class should call it and drop the copy.A profile loaded from
winprofile.ininever passes through this page, so its headers go unchecked.