Skip to content

refactor(runtime): consolidate ownership and remove unused APIs - #9

Merged
Sau1707 merged 1 commit into
devfrom
refactor/cleanup-runtime-ownership
Oct 13, 2026
Merged

Sau1707 merged 1 commit into
devfrom
refactor/cleanup-runtime-ownership

Conversation

@Sau1707

@Sau1707 Sau1707 commented Oct 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Consolidate ownership of config reloads, loopback OAuth callbacks, integration expiry, PTY controller operations, environment files, and foreign-schema invocation while preserving ordering and cancellation.
  • Remove unread TUI state, unused capabilities, restart-only connection bookkeeping, and effect-free registration layers. Share HTTP error policies, dialog dismissal, websearch registration, and persistence/process cleanup; avoid discarded shell previews.
  • Add regression coverage for handshakes, selection/focus, cancellation, persistence interleavings, schema transforms, and error precedence. Non-callable Dynamic SDK factories now receive the explicit factory diagnostic.
  • Breaking source APIs: remove the FSUtil.Interface.globUp method, ClientConnectionOptions.pageLifecycle, and foregroundIdleThreshold. External consumers must replace ancestor-glob calls and remove these browser-option/import references; browser embeds must own lifecycle handling. No database migration is needed.
  • Includes only the selected changes from this conversation. Already-merged PR refactor: simplify operation state and event ownership #7 and unselected review candidates are excluded.

Validation

  • Root bun run check, diff/staged-diff checks, and protocol/client generated-contract checks passed; generated outputs unchanged.
  • Package-directory tests: 669 passed, 1 skipped, 0 failed — Core 344, TUI 92, Client 118, CLI 31, Server 84. Server used its full suite; other packages used affected existing suites and new regressions. Mercurial coverage was skipped because hg is unavailable.
  • Node OAuth callback smoke passed for routing, admission, duplicate rejection, completion, and interruption. Expected recovery/callback-error logs and server listener warnings appeared in passing tests.
  • Prettier across all changed source/tests fails only on existing formatting in devtools-bar.tsx, home/footer.tsx, and ui/dialog.tsx; the same failures were confirmed on the base commit. All other changed files passed; unrelated formatting was not changed.
  • Full repository behavioral suites, full Node provider tests, and browser verification were not run. Automatic editor reconnect timing, direct expiry child-process termination, and a complete CLI replacement through the new admission test remain coverage limits.

Share config reload, OAuth callback, integration expiry, PTY controller, environment file, and validator workflows. Remove unread TUI state and redundant registration layers; simplify reconnect, preview, persistence, and process policies.

Add regression coverage for cancellation, persistence interleavings, selection, focus, schema transforms, and error precedence.

BREAKING CHANGE: remove FSUtil.globUp, ClientConnectionOptions.pageLifecycle, and foregroundIdleThreshold. External consumers must update these references and own browser lifecycle handling. No database migration is required.
@Sau1707 Sau1707 added the enhancement New feature or request label Oct 13, 2026
@Sau1707
Sau1707 merged commit 8f0cc59 into dev Oct 13, 2026
2 checks passed
@Sau1707
Sau1707 deleted the refactor/cleanup-runtime-ownership branch October 14, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant