feat(opy): complete source semantic and project state convergence - #155
Merged
Conversation
Teakowa
requested changes
Sep 1, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
Major — crates/opy-rs/src/lower.rs:1349
Player-variable member lowering is still limited to the four hard-coded context names. #143 explicitly requires the receiver/source-variable contract for all valid player expressions. The reference parser treats any non-call member whose name is a player variable as __playerVar__(parse(receiver), name); e.g. a declared globalvar target followed by target.isWeaponBroken is a player-variable access, while this code falls through to HirExpr::Member (and non-Name receivers still become unsupported-member).
Resolve declared/default player-variable members independently of receiver shape, preserving the lowered receiver and member provenance.
Honor declared player-variable members for global-variable and call-result receivers while preserving the existing implicit-global default-name behavior. Refs #143
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventPlayer,hostPlayer,attacker, andvictimwith HIR provenance and structured invalid-member diagnosticssettingsblock from included sources, preserve its source file identity, and ignore duplicate includes after first processingVerification
cargo fmt --all -- --checkcargo test --workspace --all-targetsFixes #142
Fixes #143